Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: complete migration of volrep to csi-addons #3314

Closed
5 tasks done
Rakshith-R opened this issue Aug 18, 2022 · 14 comments · Fixed by #3924
Closed
5 tasks done

rbd: complete migration of volrep to csi-addons #3314

Rakshith-R opened this issue Aug 18, 2022 · 14 comments · Fixed by #3924
Assignees
@riya-singhal31
Labels
cleanup dependency/csi-addons Related to a CSI-Addons issue or enhancement keepalive This label can be used to disable stale bot activiity in the repo
Milestone
release-v3.9.0

Comments

@Rakshith-R
Copy link
Contributor

Rakshith-R commented Aug 18, 2022 •
edited
Loading

TODO's:

Originally posted by @nixpanic in #3305 (comment)
@Rakshith-R Rakshith-R added this to the release-3.8 milestone Aug 18, 2022
This was referenced Aug 18, 2022
Merged
Closed
@nixpanic nixpanic added cleanup dependency/csi-addons Related to a CSI-Addons issue or enhancement labels Aug 22, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Sep 28, 2022
@Madhu-1 Madhu-1 added keepalive This label can be used to disable stale bot activiity in the repo and removed wontfix This will not be worked on labels Oct 3, 2022
@eyenx eyenx mentioned this issue Oct 19, 2022
Merged
6 tasks
@yati1998
Copy link
Contributor

@Rakshith-R I guess all the task here is done already. Can you confirm and close the issue, if done?

@Rakshith-R
Copy link
Contributor Author

@Rakshith-R I guess all the task here is done already. Can you confirm and close the issue, if done?

No, 3 out of 4 TODOs are still not done.

@riya-singhal31 do you wanna take up this issue ?

@yati1998
Copy link
Contributor

@Rakshith-R I guess all the task here is done already. Can you confirm and close the issue, if done?

No, 3 out of 4 TODOs are still not done.
cool
@riya-singhal31 do you wanna take up this issue ?
yeah would be a good one

@riya-singhal31 riya-singhal31 mentioned this issue Jan 12, 2023
Merged
@Madhu-1 Madhu-1 modified the milestones: release-3.8, release-v3.9 Feb 23, 2023
@riya-singhal31
Copy link
Contributor

Closes with - #3608

@Rakshith-R
Copy link
Contributor Author

Closes with - #3608

you mean updates,

Make sure to address this comment too.
three more tasks are remaining including the above one.

@riya-singhal31
Copy link
Contributor

riya-singhal31 commented Apr 24, 2023 •
edited
Loading

add minimal unit tests like internal/csi-addons/rbd/reclaimspace_test.go
There is already a test file for replication.go, moved it to csi-addons. Do we need to add some more tests to it?
cc @Rakshith-R

@Rakshith-R
Copy link
Contributor Author

add minimal unit tests like internal/csi-addons/rbd/reclaimspace_test.go

There is already a test file for replication.go, moved it to csi-addons. Do we need to add some more tests to it?
cc @Rakshith-R

They need to be added after completion of task 3 remove replication service from controller server
refer https://github.com/ceph/ceph-csi/blob/devel/internal/csi-addons/rbd/reclaimspace_test.go.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 30, 2023

@riya-singhal31 any updates here?

@riya-singhal31
Copy link
Contributor

@riya-singhal31 any updates here?

Yes, sending an updated PR.

@riya-singhal31 riya-singhal31 mentioned this issue Jun 5, 2023
Merged
@riya-singhal31
Copy link
Contributor

#3884 - addresses all the rest sub-items.

@riya-singhal31
Copy link
Contributor

riya-singhal31 commented Jun 16, 2023 •
edited
Loading

remove replication service from controller server

@Rakshith-R can you please elaborate on it. My understanding is that we want to remove the replication import from the files in internal/rbd, or something else is also needed here?

Have done this here, #3884

@Rakshith-R
Copy link
Contributor Author

remove replication service from controller server

@Rakshith-R can you please elaborate on it. My understanding is that we want to remove the replication import from the files in internal/rbd, or something else is also needed here?

Have done this here, #3884

replication server still needs to be removed from rbd driver completely.
https://github.com/ceph/ceph-csi/blob/devel/internal/rbd/driver/driver.go#L69

@riya-singhal31
Copy link
Contributor

remove replication service from controller server

@Rakshith-R can you please elaborate on it. My understanding is that we want to remove the replication import from the files in internal/rbd, or something else is also needed here?
Have done this here, #3884

replication server still needs to be removed from rbd driver completely. https://github.com/ceph/ceph-csi/blob/devel/internal/rbd/driver/driver.go#L69

Okay, thanks Rakshith.

@Rakshith-R Rakshith-R linked a pull request Jun 23, 2023 that will close this issue
rbd: migration of replication service from controller server #3924
Merged
@mergify mergify bot closed this as completed in #3924 Jun 23, 2023
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Nov 3, 2023
@nixpanic
cleanup: remove left-overs of ReplicationServer in csi-common
a6a0d00 
The ReplicationServer is not used anymore, the functionality has moved
to CSI-Addons and the `internal/csi-addons/rbd` package. These last
references were not activated anywhere, so can be removed without any
impact.

See-also: ceph#3314
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic nixpanic mentioned this issue Nov 3, 2023
Merged
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Nov 3, 2023
@nixpanic
cleanup: remove left-overs of ReplicationServer in csi-common
c1b4d2a 
The ReplicationServer is not used anymore, the functionality has moved
to CSI-Addons and the `internal/csi-addons/rbd` package. These last
references were not activated anywhere, so can be removed without any
impact.

See-also: ceph#3314
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Nov 7, 2023
@nixpanic
cleanup: remove left-overs of ReplicationServer in csi-common
6d21160 
The ReplicationServer is not used anymore, the functionality has moved
to CSI-Addons and the `internal/csi-addons/rbd` package. These last
references were not activated anywhere, so can be removed without any
impact.

See-also: ceph#3314
Signed-off-by: Niels de Vos <ndevos@ibm.com>
mergify bot pushed a commit that referenced this issue Nov 7, 2023
@nixpanic @mergify
cleanup: remove left-overs of ReplicationServer in csi-common
76d9400 
The ReplicationServer is not used anymore, the functionality has moved
to CSI-Addons and the `internal/csi-addons/rbd` package. These last
references were not activated anywhere, so can be removed without any
impact.

See-also: #3314
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riya-singhal31 riya-singhal31

Labels
cleanup dependency/csi-addons Related to a CSI-Addons issue or enhancement keepalive This label can be used to disable stale bot activiity in the repo
Projects
None yet
Milestone
release-v3.9.0
Development

Successfully merging a pull request may close this issue.

rbd: migration of replication service from controller server
5 participants
@nixpanic @Madhu-1 @yati1998 @Rakshith-R @riya-singhal31