Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change limit INODES rbd device #374

Closed
dllozhkin opened this issue May 14, 2019 · 7 comments
Closed

Change limit INODES rbd device #374

dllozhkin opened this issue May 14, 2019 · 7 comments
Assignees
@nixpanic
Labels
backport-to-release-v3.8 backport to release 3.8 branch component/rbd Issues related to RBD dependency/k8s depends on Kubernetes features enhancement New feature or request
Milestone
release-v3.8.1

Comments

@dllozhkin
Copy link

dllozhkin commented May 14, 2019 •
edited
Loading

I trying formatting device real time, but I can't doing that because device is busy
mkfs -t ext4 -N iNumberOfINodes /dev/XdY
/dev/rbd11 is mounted; will not make a filesystem here!

How I can change limit inodes for my rbd block?
@dllozhkin dllozhkin changed the title Change limit INNODES rbd device Change limit INODES rbd device May 14, 2019
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 11, 2019

CC @dillaman

@nixpanic nixpanic added component/rbd Issues related to RBD enhancement New feature or request labels Apr 17, 2020
@nixpanic
Copy link
Member

Related to #626, although that is a parameter to the StorageClass and the number of inodes is surely a configuration attribute for the PV (as it depends on the size).

Alternatively XFS can be used, it dynamically allocates inodes so there is no practical limit.

@nixpanic nixpanic mentioned this issue Apr 28, 2020
Closed
@nixpanic nixpanic added the dependency/k8s depends on Kubernetes features label Apr 28, 2020
@nixpanic
Copy link
Member

Also, this feature is probably useful in the Kubernetes external-provisioner. So maybe it should get implemented there, and not in Ceph-CSI directly.

nixpanic added a commit to nixpanic/csi-spec that referenced this issue Apr 29, 2020
@nixpanic
Add mkfs_options to VolumeCapability
ff39529 
Make it possible to add options to `mkfs` for formatting a filesystem.
With additional options to create a filesystem on a volume, provisioners
can be instructed to enable/disable certain features that may not be
available on all nodes.

See-also: ceph/ceph-csi#374
Fixes: container-storage-interface#402
nixpanic added a commit to nixpanic/csi-spec that referenced this issue Apr 29, 2020
@nixpanic
Add mkfs_options to VolumeCapability.MountVolume
69b1454 
Make it possible to add options to `mkfs` for formatting a filesystem.
With additional options to create a filesystem on a volume, provisioners
can be instructed to enable/disable certain features that may not be
available on all nodes.

See-also: ceph/ceph-csi#374
Fixes: container-storage-interface#402
@nixpanic nixpanic mentioned this issue Apr 29, 2020
Closed
nixpanic added a commit to nixpanic/csi-spec that referenced this issue Apr 29, 2020
@nixpanic
Add mkfs_options to VolumeCapability.MountVolume
87024a7 
Make it possible to add options to `mkfs` for formatting a filesystem.
With additional options to create a filesystem on a volume, provisioners
can be instructed to enable/disable certain features that may not be
available on all nodes.

See-also: ceph/ceph-csi#374
Fixes: container-storage-interface#402
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 4, 2020
@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@stale stale bot closed this as completed Oct 12, 2020
@nixpanic nixpanic removed the wontfix This will not be worked on label Feb 23, 2023
@nixpanic nixpanic self-assigned this Feb 23, 2023
@nixpanic
Copy link
Member

By placing mkfsOptions in the VolumeContext, the NodeStageVolume procedure can access the options and use it for formatting the filesystem. The mkfsOptions can be placed in the StorageClass.

@nixpanic nixpanic reopened this Feb 23, 2023
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Feb 23, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
f780d74 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Feb 23, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
bc9e3d9 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Feb 27, 2023

By placing mkfsOptions in the VolumeContext, the NodeStageVolume procedure can access the options and use it for formatting the filesystem. The mkfsOptions can be placed in the StorageClass.

Yes, this is an option that can be applicable only for the SP. and it cannot be changed dynamically as it will be stored in volumeAttributes of the PV object.

@Rakshith-R Rakshith-R added this to the release-v3.8.1 milestone Mar 1, 2023
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 2, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
abd2764 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 2, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
bee406b 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 2, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
3a71c66 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 2, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
c2e5428 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 3, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
eaaa059 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 3, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
5f0b2e2 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 6, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
208e8b4 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 6, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
afe5eea 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 6, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
c3cf64a 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 7, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
0c6c1f5 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
nixpanic added a commit to nixpanic/ceph-csi that referenced this issue Mar 8, 2023
@nixpanic
rbd: allow setting mkfsOptions in the StorageClass
8d2f13d 
Add `mkfsOptions` to the StorageClass and pass them to the `mkfs`
command while creating the filesystem on the RBD device.

Fixes: ceph#374
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@mergify mergify bot closed this as completed in a467820 Mar 8, 2023
@nixpanic nixpanic added the backport-to-release-v3.8 backport to release 3.8 branch label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nixpanic nixpanic

Labels
backport-to-release-v3.8 backport to release 3.8 branch component/rbd Issues related to RBD dependency/k8s depends on Kubernetes features enhancement New feature or request
Projects
None yet
Milestone
release-v3.8.1
Development

No branches or pull requests
4 participants
@nixpanic @Madhu-1 @dllozhkin @Rakshith-R