Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for older kubernetes/ceph releases #4168

Closed
Madhu-1 opened this issue Oct 9, 2023 · 5 comments · Fixed by #4262
Closed

remove support for older kubernetes/ceph releases #4168

Madhu-1 opened this issue Oct 9, 2023 · 5 comments · Fixed by #4262
Assignees
Labels
keepalive This label can be used to disable stale bot activiity in the repo

Comments

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 9, 2023

Update the Readme and code where we have added support for older ceph or kubernetes versions. Octopus is already EOL we can remove it from Readme support. also check code for cephfs resize/subvolume metadata related operations as well.

Copy link

github-actions bot commented Nov 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the wontfix This will not be worked on label Nov 8, 2023
@Madhu-1 Madhu-1 added keepalive This label can be used to disable stale bot activiity in the repo and removed wontfix This will not be worked on labels Nov 9, 2023
@Madhu-1 Madhu-1 added this to the release-v3.10.0 milestone Nov 9, 2023
@Rakshith-R
Copy link
Contributor

hey @karthik-us ,
This is part of 3.10 milestone.
Can you prioritize this issue to get it done within this week or early next week ?

Thanks,

@karthik-us
Copy link
Collaborator

Sure @Rakshith-R.

@karthik-us
Copy link
Collaborator

karthik-us commented Nov 16, 2023

@Madhu-1 can you please elaborate on this one please?

also check code for cephfs resize/subvolume metadata related operations as well.

If you can point me to the changesets which requires changes in these parts of the codes, that would be great.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 16, 2023

func (s *subVolumeClient) supportsSubVolMetadata() bool {
newLocalClusterState(s.clusterID)
return clusterAdditionalInfo[s.clusterID].subVolMetadataState != unsupported
}
func (s *subVolumeClient) isUnsupportedSubVolMetadata(err error) bool {
var invalid fsAdmin.NotImplementedError
if err != nil && errors.As(err, &invalid) {
// In case the error is other than invalid command return error to the caller.
clusterAdditionalInfo[s.clusterID].subVolMetadataState = unsupported
return false
}
clusterAdditionalInfo[s.clusterID].subVolMetadataState = supported
return true
}
if clusterAdditionalInfo[s.clusterID].resizeState == unknown ||
clusterAdditionalInfo[s.clusterID].resizeState == supported {
fsa, err := s.conn.GetFSAdmin()
if err != nil {
log.ErrorLog(ctx, "could not get FSAdmin, can not resize volume %s:", s.FsName, err)
return err
}
_, err = fsa.ResizeSubVolume(s.FsName, s.SubvolumeGroup, s.VolID, fsAdmin.ByteCount(bytesQuota), true)
if err == nil {
clusterAdditionalInfo[s.clusterID].resizeState = supported
return nil
}
var invalid fsAdmin.NotImplementedError
// In case the error is other than invalid command return error to the caller.
if !errors.As(err, &invalid) {
log.ErrorLog(ctx, "failed to resize subvolume %s in fs %s: %s", s.VolID, s.FsName, err)
return err
}
}
clusterAdditionalInfo[s.clusterID].resizeState = unsupported
s.Size = bytesQuota
return s.CreateVolume(ctx)

karthik-us added a commit to karthik-us/ceph-csi that referenced this issue Nov 17, 2023
Updating the support matrix to point to the suppotred ceph release.

Fixes: ceph#4168
Signed-off-by: karthik-us <ksubrahm@redhat.com>
karthik-us added a commit to karthik-us/ceph-csi that referenced this issue Nov 17, 2023
Updating the support matrix to point to the suppotred ceph release.

Fixes: ceph#4168
Signed-off-by: karthik-us <ksubrahm@redhat.com>
karthik-us added a commit to karthik-us/ceph-csi that referenced this issue Nov 22, 2023
Updating the support matrix to point to the suppotred ceph release.

Fixes: ceph#4168
Signed-off-by: karthik-us <ksubrahm@redhat.com>
nixpanic pushed a commit to karthik-us/ceph-csi that referenced this issue Nov 23, 2023
Updating the support matrix to point to the suppotred ceph release.

Fixes: ceph#4168
Signed-off-by: karthik-us <ksubrahm@redhat.com>
@mergify mergify bot closed this as completed in #4262 Nov 23, 2023
mergify bot pushed a commit that referenced this issue Nov 23, 2023
Updating the support matrix to point to the suppotred ceph release.

Fixes: #4168
Signed-off-by: karthik-us <ksubrahm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive This label can be used to disable stale bot activiity in the repo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants