-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make seLinuxMount optional in CSIDriver for compatibility #4437
Comments
Note that Ceph-CSI 3.10.x is not tested with Kubernetes 1.25.x. Ceph-CSI 3.10.x expects Kubernetes 1.26 or newer. The Ceph-CSI CI runs tests on Kubernetes 1.26, so I wonder why there were no issues with deploying there. Maybe @Rakshith-R has an idea? |
In k8s 1.26, it seems k8s accepts that option but it doesn't show up if the feature flag is not enabled. As Niels already mentioned 3.10.x expects k8s 1.26+ . |
Hi @Rakshith-R I can't agree, as helm allows easily develop backward compatible charts and except this issue there actually no issues in running ceph-csi 3.10.x on K8s 1.24.x for example. The fact that soft was or not was tested doesn't mean we should accept breaking changes for non-tested versions just in helm when helm can be easily backward compatible. Same approach can be found in many other public helm charts like prometheus, thanos, etc... |
Signed-off-by: Ruslan Khizhnyak <rkhizhnyak@ptsecurity.com>
Describe the bug
According to https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ the seLinuxMount field in the CSIDriver object is introduced as alpha in K8S 1.25, made beta in 1.27 and only starting from 1.28 defaults to true.
If this feature gate is not enabled, ceph-csi-rbd and ceph-csi-fs fail when installing.
I would like for seLinuxMount to be optional but true by default, to have better compatibility
This was enabled on tag 3.10.2. Previous tags did not have this issue. See PR #4346
Environment details
fuse
orkernel
. for rbd itskrbd
orrbd-nbd
) : krbdSteps to reproduce
Steps to reproduce the behavior:
unknown field "seLinuxMount" in io.k8s.api.storage.v1.CSIDriverSpec
Actual results
Chart failed to install
Expected behavior
Chart installs correctly or shows a descriptive error about the feature flag
The text was updated successfully, but these errors were encountered: