Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Include seLinuxMount only if KubeVersion greater or equal of 1.25 #4475

Merged
merged 1 commit into from
Mar 13, 2024
Merged

helm: Include seLinuxMount only if KubeVersion greater or equal of 1.25 #4475

merged 1 commit into from
Mar 13, 2024

Conversation

dragoangel
Copy link
Contributor

@dragoangel dragoangel commented Mar 5, 2024 •
edited
Loading

Describe what this PR does

Fix chart to be compatible with kube version lower then 1.25.0

Is there anything that requires special attention

Do you have any questions?
Yes, I don't see where to bounce helm chart version, version: 3-canary looks not legit

Is the change backward compatible?
Yes

Are there concerns around backward compatibility?
No

Provide any external context for the change, if any.
Desribed in issue #4474

Related issues

Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.

Fixes: #4474
Fixes: #4437

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@dragoangel dragoangel changed the title charts: Include seLinuxMount only if KubeVersion greater or equal of 1.25.0 helm: Include seLinuxMount only if KubeVersion greater or equal of 1.25.0 Mar 5, 2024
@mergify mergify bot added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Mar 5, 2024
@nixpanic nixpanic requested a review from Rakshith-R March 5, 2024 12:16
@nixpanic
Copy link
Member

nixpanic commented Mar 5, 2024

Yes, I don't see where to bounce helm chart version, version: 3-canary looks not legit

The version gets updated to something real when a release is made.

@dragoangel
Copy link
Contributor Author

dragoangel commented Mar 5, 2024 •
edited
Loading

Yes, I don't see where to bounce helm chart version, version: 3-canary looks not legit

The version gets updated to something real when a release is made.

Hi @nixpanic , I also get such feeling by checking git history, but was not sure to 100%, thanks

@nixpanic nixpanic added the ci/skip/multi-arch-build skip building on multiple architectures label Mar 5, 2024
@nixpanic
Copy link
Member

nixpanic commented Mar 5, 2024

@dragoangel , it seems the subject of the commit it a little too long. commitlint complains about it:

✖ header must not be longer than 72 characters, current length is 73 [header-max-length]

@dragoangel
Copy link
Contributor Author

@dragoangel , it seems the subject of the commit it a little too long. commitlint complains about it:

✖ header must not be longer than 72 characters, current length is 73 [header-max-length]

Will fix, thanks

@dragoangel dragoangel changed the title helm: Include seLinuxMount only if KubeVersion greater or equal of 1.25.0 helm: Include seLinuxMount only if KubeVersion greater or equal of 1.25 Mar 5, 2024
@dragoangel dragoangel force-pushed the fix-csidriver-crd branch 2 times, most recently from a4bfd61 to cf5dd16 Compare March 8, 2024 09:17
@dragoangel
Copy link
Contributor Author

dragoangel commented Mar 11, 2024 •
edited
Loading

@iPraveenParihar @Rakshith-R can you please review this PR?

Rakshith-R
Rakshith-R approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nixpanic
Copy link
Member

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Mar 12, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@nixpanic
Copy link
Member

@nixpanic looks not okay?

Sometimes the CI environment fails to pull container images. Hopefully a retest of the failed jobs works now.

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic
Copy link
Member

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024

refresh

✅ Pull request refreshed

@nixpanic nixpanic added the ci/skip/e2e skip running e2e CI jobs label Mar 12, 2024
@nixpanic
Copy link
Member

@Mergifyio rebase

@dragoangel @nixpanic
helm: Include seLinuxMount only if KubeVersion greater or equal of 1.25
3d1b381 
Signed-off-by: Dmytro Alieksieiev <1865999+dragoangel@users.noreply.github.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

@Mergifyio queue

🤞

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Mar 12, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 12, 2024
@dragoangel
Copy link
Contributor Author

@nixpanic , multi-arch-build build failed 😓

@mergify mergify bot merged commit fcaac58 into ceph:devel Mar 13, 2024
35 checks passed
@dragoangel dragoangel deleted the fix-csidriver-crd branch March 13, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/deployment Helm chart, kubernetes templates and configuration Issues/PRs
Projects
None yet
Milestone
No milestone
5 participants
@dragoangel @nixpanic @ceph-csi-bot @iPraveenParihar @Rakshith-R