Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restoreSize is missing at snapshots after ceph-csi-rbd 12.1 #4788

Closed
dragoangel opened this issue Aug 20, 2024 · 3 comments · Fixed by #4791
Closed

restoreSize is missing at snapshots after ceph-csi-rbd 12.1 #4788

dragoangel opened this issue Aug 20, 2024 · 3 comments · Fixed by #4791
Assignees
@Madhu-1
Labels
bug Something isn't working component/rbd Issues related to RBD

Comments

@dragoangel
Copy link
Contributor

dragoangel commented Aug 20, 2024 •
edited
Loading

Describe the bug

After updating to ceph-csi-rbd 12.1 from 11.0 new snapshots missing restoreSize details.

Environment details

  • Image/version of Ceph CSI driver : 12.1
  • Helm chart version : v3.15.2
  • Kernel version : 5.15.0-101-generic
  • Mounter used for mounting PVC (for cephFS its fuse or kernel. for rbd its
    krbd or rbd-nbd) : krbd
  • Kubernetes cluster version : v1.25.14
  • Ceph cluster version : 17.2.7 quincy (stable)

Steps to reproduce

Steps to reproduce the behavior:

  1. Deploy ceph-csi-rbd chart https://ceph.github.io/csi-charts ~3.12.0
  2. Deploy snapshot-controller chart https://piraeus.io/helm-charts ~3.0.5
  3. Create PVC
  4. Create snapshot of PVC
  5. Look at volumesnapshots.snapshot.storage.k8s.io and at volumesnapshotcontents.snapshot.storage.k8s.io for newly created snapshot - it will be missing restoreSize
  6. Downgrade ceph-csi-rbd chart to 3.11.0 version
  7. Delete snapshot and create it from scratch
  8. Check volumesnapshots.snapshot.storage.k8s.io and at volumesnapshotcontents.snapshot.storage.k8s.io for newly created snapshot - both resourses will get restoreSize attribute

Actual results

snapshots missing restoreSize details

Expected behavior

snapshots must have restoreSize details that represents size of rbd image

Logs

unfortunetly logs are not provide any related details or errors, at least at default logs verbosity

Additional context

I checked ceph-csi-cephfs and this issue not reproduces there, so issue exactly in rdb realization.
@iPraveenParihar
Copy link
Contributor

v3.12.0 has latest external-snapshotter v8. I see PR kubernetes-csi/external-snapshotter#1011 related to restoreSize by @Madhu-1.

@Madhu-1 can you please take a look?

Madhu-1 added a commit to Madhu-1/ceph-csi that referenced this issue Aug 21, 2024
@Madhu-1
rbd: add image size in toSnapshot
c44c09d 
we need to return the rbd image size
as a snapshot size in CreateSnapshot
Response.

fixes: ceph#4788

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 21, 2024

v3.12.0 has latest external-snapshotter v8. I see PR kubernetes-csi/external-snapshotter#1011 related to restoreSize by @Madhu-1.

@Madhu-1 can you please take a look?

This is a bug in cephcsi not in external-snapshotter

@Madhu-1 Madhu-1 mentioned this issue Aug 21, 2024
Merged
@Madhu-1 Madhu-1 self-assigned this Aug 21, 2024
@Madhu-1 Madhu-1 added bug Something isn't working component/rbd Issues related to RBD labels Aug 21, 2024
@dragoangel
Copy link
Contributor Author

Hi @Madhu-1, thanks for taking onto it :)

nixpanic pushed a commit to Madhu-1/ceph-csi that referenced this issue Aug 21, 2024
@Madhu-1 @nixpanic
rbd: add image size in toSnapshot
a6a5794 
we need to return the rbd image size
as a snapshot size in CreateSnapshot
Response.

fixes: ceph#4788

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@mergify mergify bot closed this as completed in #4791 Aug 21, 2024
@mergify mergify bot closed this as completed in 38fd27a Aug 21, 2024
mergify bot pushed a commit that referenced this issue Aug 21, 2024
@Madhu-1 @mergify
rbd: add image size in toSnapshot
e3d4f57 
we need to return the rbd image size
as a snapshot size in CreateSnapshot
Response.

fixes: #4788

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 38fd27a)
@mergify mergify bot mentioned this issue Aug 21, 2024
Merged
nixpanic pushed a commit that referenced this issue Aug 22, 2024
@Madhu-1 @nixpanic
rbd: add image size in toSnapshot
9e18721 
we need to return the rbd image size
as a snapshot size in CreateSnapshot
Response.

fixes: #4788

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 38fd27a)
mergify bot pushed a commit that referenced this issue Aug 22, 2024
@Madhu-1 @mergify
rbd: add image size in toSnapshot
02a7994 
we need to return the rbd image size
as a snapshot size in CreateSnapshot
Response.

fixes: #4788

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 38fd27a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Madhu-1 Madhu-1

Labels
bug Something isn't working component/rbd Issues related to RBD
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rbd: add image size in toSnapshot Madhu-1/ceph-csi
3 participants
@dragoangel @Madhu-1 @iPraveenParihar