Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowing kernel mount for versions of kernel version < 4.17 #617

Closed
yydzhou opened this issue Sep 16, 2019 · 6 comments
Closed

allowing kernel mount for versions of kernel version < 4.17 #617

yydzhou opened this issue Sep 16, 2019 · 6 comments

Comments

@yydzhou
Copy link

yydzhou commented Sep 16, 2019 •
edited
Loading

Describe the feature you'd like to have

Kernel mount for cephfs on kernel version < 4.17

What new functionality do you want?

When the mounter: kernel is specified in the storage class, the csi should do their best to use the specified mounter even through this may result in lose some features.

What is the value to the end user? (why is it a priority?)

There are a couple reasons.

  1. The kernel has better performance on latency and throughput, this is important for some latency sensitive applications.
  2. The kernel mounting is much more stable as the FUSE has the issue cephcsi-cephfs nodeplugin pod got OOM killing when using FUSE mounter #554
  3. This request is actually to match the default behavior of previous csi version as well as the old external provisioners. There is no quota support for a long time, and existing users are good with it. However, the new version of cephfs-csi changed this behavior (forces use FUSE mount when kernel < 4.17 https://github.com/ceph/ceph-csi/blob/master/pkg/cephfs/volumemounter.go#L73), which results a lot more effort needed for an upgrade.

In addition, kernel 4.17 is toooo new for production requirement as the current Long time support kernel is 4.14. https://www.kernel.org/category/releases.html. There is 4.19 claimed to be long time support, but its support will end in next year. I think this enforcement should be delayed until there is a real long term support kernel version >= 4.17.

How would the end user gain value from having this feature?

How will we know we have a good solution? (acceptance criteria)

Add a list of criteria that should be met for this feature to be useful

Additional context

Add any other context or screenshots about the feature request here.
@vicaya
Copy link

vicaya commented Sep 16, 2019

Quota and snapshot are usually an optional features that are not used by default in many deployments. Hard code 4.17+ for using kernel client seems unreasonable. 4.14 (a LTS release)+ with warnings for missing features, would be a more reasonable default. At a minimum, there should be an option to override default behavior.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 18, 2019

@humblec can this be fixed before 1.2.1 release?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 18, 2019

CC @poornimag @ajarr

poornimag pushed a commit to poornimag/ceph-csi that referenced this issue Sep 18, 2019
cephfs: Choose kernel mounter when storage class mounter is kernel
53a6ada 
Currently, the kernel mounter is chosen only when the kernel version is >= 4.17,
as the quota feature required for PV creation, is not available in older kernels.
With this patch we are changing the behaviour to choose kernel mounter if the
mounter spcified in SC is kernel, irrsepective of the kernel version.

Fixes ceph#617

Signed-off-by: Poornima G <pgurusid@redhat.com>
@poornimag poornimag mentioned this issue Sep 18, 2019
Closed
poornimag pushed a commit to poornimag/ceph-csi that referenced this issue Sep 18, 2019
cephfs: Choose kernel mounter when storage class mounter is kernel
7fd034a 
Currently, the kernel mounter is chosen only when the kernel version is >= 4.17,
as the quota feature required for PV creation, is not available in older kernels.
With this patch we are changing the behaviour to choose kernel mounter if the
mounter specified in SC is kernel, irrespective of the kernel version.

Fixes ceph#617

Signed-off-by: Poornima G <pgurusid@redhat.com>
poornimag pushed a commit to poornimag/ceph-csi that referenced this issue Sep 18, 2019
cephfs: Choose kernel mounter when storage class mounter is kernel
76a7bfb 
Currently, the kernel mounter is chosen only when the kernel version is >= 4.17,
as the quota feature required for PV creation, is not available in older kernels.
With this patch we are changing the behaviour to choose kernel mounter if the
mounter specified in SC is kernel, irrespective of the kernel version.

Fixes ceph#617

Signed-off-by: Poornima G <pgurusid@redhat.com>
poornimag pushed a commit to poornimag/ceph-csi that referenced this issue Sep 18, 2019
cephfs: Choose kernel mounter when storage class mounter is kernel
0d93b08 
Currently, the kernel mounter is chosen only when the kernel version is >= 4.17,
as the quota feature required for PV creation, is not available in older kernels.
With this patch we are changing the behaviour to choose kernel mounter if the
mounter specified in SC is kernel, irrespective of the kernel version.

Fixes ceph#617

Signed-off-by: Poornima G <pgurusid@redhat.com>
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 18, 2019

@vicaya @yydzhou please check #623 (comment)

poornimag pushed a commit to poornimag/ceph-csi that referenced this issue Sep 18, 2019
cephfs: Choose kernel mounter when storage class mounter is kernel
d26e528 
Currently, the kernel mounter is chosen only when the kernel version is >= 4.17,
as the quota feature required for PV creation, is not available in older kernels.
With this patch we are changing the behaviour to choose kernel mounter if the
mounter specified in SC is kernel, irrespective of the kernel version.

Fixes ceph#617

Signed-off-by: Poornima G <pgurusid@redhat.com>
@yydzhou
Copy link
Author

yydzhou commented Sep 18, 2019

@vicaya @yydzhou please check #623 (comment)

@Madhu-1 and @poornimag Thanks for your quick response and action.

@humblec humblec mentioned this issue Oct 1, 2019
Merged
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Feb 5, 2020

closing as this is fixed

@Madhu-1 Madhu-1 closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cephfs: Choose kernel mounter when mounter specified is kernel poornimag/ceph-csi
3 participants
@vicaya @yydzhou @Madhu-1