Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: refuse to create block volumes #110

Merged
merged 1 commit into from
Jan 9, 2019

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Dec 13, 2018

Without this check, the driver fails one of the E2E storage tests in
Kubernetes 1.13: provisioning a block volume is expected to fail in
https://github.com/kubernetes/kubernetes/blob/e689d515f77cda51898045d626ec4070e3328194/test/e2e/storage/testsuites/volumemode.go#L329-L330

Without this check, the driver fails one of the E2E storage tests in
Kubernetes 1.13: provisioning a block volume is expected to fail in
https://github.com/kubernetes/kubernetes/blob/e689d515f77cda51898045d626ec4070e3328194/test/e2e/storage/testsuites/volumemode.go#L329-L330
@pohly
Copy link
Contributor Author

pohly commented Dec 13, 2018

The same check was already merged into the hostpath driver, see kubernetes-retired/drivers#125

@gman0
Copy link
Contributor

gman0 commented Dec 18, 2018

@rootfs how does this fare againts #97 ?

@rootfs
Copy link
Member

rootfs commented Jan 7, 2019

ping @mkimuram

@mkimuram
Copy link
Contributor

mkimuram commented Jan 8, 2019

@pohly

I agree that this check is needed until csi rbd driver supports block feature.
I have been working on adding this feature to csi rbd driver, but I don't think that I will complete that work, soon.

So, please merge this first.

@pohly
Copy link
Contributor Author

pohly commented Jan 9, 2019

@rootfs or @gman0: please merge.

@gman0
Copy link
Contributor

gman0 commented Jan 9, 2019

Thanks @pohly for the work and thanks @mkimuram for the comment.

@gman0 gman0 merged commit 3170ec4 into ceph:master Jan 9, 2019
wilmardo pushed a commit to wilmardo/ceph-csi that referenced this pull request Jul 29, 2019
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ceph-csi that referenced this pull request Jul 27, 2022
Sync with upstream devel branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants