rbd: check volume details from original volumeID #2931

Madhu-1 · 2022-03-10T12:02:19Z

Checking volume details for the existing volumeID first. if details like OMAP, RBD Image, Pool does not exist try to use clusterIDMapping to look for the correct pieces of information.

fixes: #2929

Signed-off-by: Madhu Rajanna madhupr007@gmail.com

Facing some CI issue and looks like its due to the rbd issue https://tracker.ceph.com/issues/54593

Madhu-1 · 2022-03-11T05:39:12Z

/retest all

Madhu-1 · 2022-03-11T05:39:26Z

/retest all

something wrong with CI restarting all tests

humblec · 2022-03-14T11:07:53Z

hmmm.. just wondering how it react to migrated volume handle.

Madhu-1 · 2022-03-14T11:09:28Z

hmmm.. just wondering how it react to migrated volume handle.

@humblec what is the concern here?

Madhu-1 · 2022-03-14T12:04:22Z

/test all

humblec · 2022-03-15T07:55:37Z

hmmm.. just wondering how it react to migrated volume handle.

@humblec what is the concern here?

looking some more into this, ideally we should be good, that said the static volume ID is untouched and should folow the code path as before, for new volume Handles only the change in effect . @Madhu-1 can you please double confirm ?

Madhu-1 · 2022-03-15T10:04:40Z

hmmm.. just wondering how it react to migrated volume handle.

@humblec what is the concern here?

looking some more into this, ideally we should be good, that said the static volume ID is untouched and should folow the code path as before, for new volume Handles only the change in effect . @Madhu-1 can you please double confirm ?

Yes this is not for static volume its for dynamic volume already getting called in DeleteVolume Code

ceph-csi/internal/rbd/controllerserver.go

Lines 762 to 766 in c3e35f8

    
           rbdVol, err := GenVolFromVolID(ctx, volumeID, cr, req.GetSecrets()) 
        
           defer rbdVol.Destroy() 
        
           if err != nil { 
        
           	return cs.checkErrAndUndoReserve(ctx, err, volumeID, rbdVol, cr) 
        
           }

Madhu-1 · 2022-03-15T10:16:47Z

/retest ci/centos/mini-e2e-helm/k8s-1.21

Madhu-1 · 2022-03-15T10:16:56Z

/retest ci/centos/mini-e2e-helm/k8s-1.23

Madhu-1 · 2022-03-15T10:17:16Z

/retest ci/centos/mini-e2e/k8s-1.21

Madhu-1 · 2022-03-15T10:17:28Z

/retest ci/centos/mini-e2e/k8s-1.23

Madhu-1 · 2022-03-15T10:18:01Z

`Mar 14 13:27:18.892: backend images not matching kubernetes resource count,image count 22 kubernetes resource count 21

backend image Info:

 [csi-vol-61a6638c-a39a-11ec-b84e-46359091d2ce csi-vol-637f4854-a39a-11ec-b84e-46359091d2ce csi-vol-637f4854-a39a-11ec-b84e-46359091d2ce-temp csi-vol-63bdd485-a39a-11ec-b84e-46359091d2ce-temp csi-vol-63db0526-a39a-11ec-b84e-46359091d2ce csi-vol-63db0526-a39a-11ec-b84e-46359091d2ce-temp csi-vol-63f96934-a39a-11ec-b84e-46359091d2ce csi-vol-63f96934-a39a-11ec-b84e-46359091d2ce-temp csi-vol-643f9696-a39a-11ec-b84e-46359091d2ce csi-vol-643f9696-a39a-11ec-b84e-46359091d2ce-temp csi-vol-6457b69e-a39a-11ec-b84e-46359091d2ce csi-vol-6457b69e-a39a-11ec-b84e-46359091d2ce-temp csi-vol-6475acf7-a39a-11ec-b84e-46359091d2ce csi-vol-6475acf7-a39a-11ec-b84e-46359091d2ce-temp csi-vol-6488cc64-a39a-11ec-b84e-46359091d2ce csi-vol-6488cc64-a39a-11ec-b84e-46359091d2ce-temp csi-vol-64c087be-a39a-11ec-b84e-46359091d2ce csi-vol-64c087be-a39a-11ec-b84e-46359091d2ce-temp csi-vol-681b9d97-a39a-11ec-b84e-46359091d2ce csi-vol-681b9d97-a39a-11ec-b84e-46359091d2ce-temp csi-vol-6876ee6d-a39a-11ec-b84e-46359091d2ce csi-vol-6876ee6d-a39a-11ec-b84e-46359091d2ce-temp

`
Failed due to known errors.

Rakshith-R · 2022-03-16T04:47:11Z

@Mergifyio rebase

Madhu-1 · 2022-03-16T11:02:55Z

/test ci/centos/mini-e2e/k8s-1.21

Madhu-1 · 2022-03-16T11:03:04Z

/retest ci/centos/mini-e2e-helm/k8s-1.21

Madhu-1 · 2022-03-16T12:37:08Z

/retest ci/centos/mini-e2e/k8s-1.21

Madhu-1 · 2022-03-17T05:08:02Z

@Mergifyio rebase

mergify · 2022-03-17T05:08:19Z

rebase

✅ Branch has been successfully rebased

nixpanic · 2022-03-20T10:40:36Z

@Mergifyio rebase

mergify · 2022-03-20T10:41:21Z

rebase

✅ Branch has been successfully rebased

mergify · 2022-03-21T08:55:31Z

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

Pull request has been modified.

Madhu-1 · 2022-11-02T10:06:19Z

/retest ci/centos/mini-e2e/k8s-1.25

nixpanic · 2022-11-02T12:44:23Z

internal/rbd/nodeserver.go

-		return nil, status.Error(codes.Internal, err.Error())
-	}
-
+	rv := &rbdVolume{}


Nit: This works, but creating an empty object before overwriting it is a little ugly.

I prefer to use this instead:

var rv *rbdVolume

nixpanic · 2022-11-02T12:45:25Z

internal/rbd/nodeserver.go

-		var vi util.CSIIdentifier
-		var imageAttributes *journal.ImageAttributes
-		err = vi.DecomposeCSIID(volID)
+		rv, err = GenVolFromVolID(ctx, volID, cr, req.GetSecrets())


Pull request has been modified.

nixpanic · 2022-11-03T15:09:19Z

@Mergifyio rebase

Checking volume details for the existing volumeID first. if details like OMAP, RBD Image, Pool doesnot exists try to use clusterIDMapping to look for the correct informations. fixes: ceph#2929 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

mergify · 2022-11-03T15:10:20Z

rebase

✅ Branch has been successfully rebased

github-actions · 2022-11-03T15:10:46Z

/test ci/centos/k8s-e2e-external-storage/1.23

github-actions · 2022-11-03T15:10:47Z

/test ci/centos/k8s-e2e-external-storage/1.24

github-actions · 2022-11-03T15:10:48Z

/test ci/centos/k8s-e2e-external-storage/1.25

github-actions · 2022-11-03T15:10:49Z

/test ci/centos/mini-e2e-helm/k8s-1.23

github-actions · 2022-11-03T15:10:50Z

/test ci/centos/mini-e2e-helm/k8s-1.24

github-actions · 2022-11-03T15:10:51Z

/test ci/centos/mini-e2e-helm/k8s-1.25

github-actions · 2022-11-03T15:10:52Z

/test ci/centos/mini-e2e/k8s-1.23

github-actions · 2022-11-03T15:10:53Z

/test ci/centos/mini-e2e/k8s-1.24

github-actions · 2022-11-03T15:10:55Z

/test ci/centos/mini-e2e/k8s-1.25

github-actions · 2022-11-03T15:10:56Z

/test ci/centos/upgrade-tests-cephfs

github-actions · 2022-11-03T15:10:57Z

/test ci/centos/upgrade-tests-rbd

mergify bot added the component/rbd Issues related to RBD label Mar 10, 2022

Rakshith-R previously approved these changes Mar 11, 2022

View reviewed changes

Rakshith-R requested review from a team March 11, 2022 10:50

humblec previously approved these changes Mar 15, 2022

View reviewed changes

Madhu-1 force-pushed the fix-2929 branch from e8b4bdc to 0992053 Compare March 17, 2022 05:08

Madhu-1 force-pushed the fix-2929 branch from 0992053 to 487cb6a Compare March 20, 2022 10:41

Madhu-1 force-pushed the fix-2929 branch from 487cb6a to 4a2ca3a Compare March 22, 2022 03:31

Madhu-1 requested a review from humblec March 22, 2022 03:31

Madhu-1 force-pushed the fix-2929 branch from 9d65af1 to c9bd0b8 Compare November 2, 2022 10:01

Madhu-1 requested review from nixpanic and Rakshith-R November 2, 2022 10:02

nixpanic previously approved these changes Nov 2, 2022

View reviewed changes

Madhu-1 force-pushed the fix-2929 branch from c9bd0b8 to 4c34dc5 Compare November 2, 2022 12:50

Madhu-1 requested a review from nixpanic November 2, 2022 12:50

nixpanic approved these changes Nov 2, 2022

View reviewed changes

nixpanic requested a review from a team November 2, 2022 13:42

Madhu-1 force-pushed the fix-2929 branch from 4c34dc5 to 7fe10aa Compare November 3, 2022 15:10

nixpanic added the ok-to-test Label to trigger E2E tests label Nov 3, 2022

Rakshith-R approved these changes Nov 4, 2022

View reviewed changes

mergify bot merged commit 07e9ded into ceph:devel Nov 4, 2022

Madhu-1 mentioned this pull request Jan 11, 2023

rbd: set disableInUseChecks on rbd volume #3605

Merged

rbd: check volume details from original volumeID #2931

rbd: check volume details from original volumeID #2931

Conversation

Madhu-1 commented Mar 10, 2022 • edited Loading

Madhu-1 commented Mar 11, 2022

Madhu-1 commented Mar 11, 2022

humblec commented Mar 14, 2022

Madhu-1 commented Mar 14, 2022

Madhu-1 commented Mar 14, 2022

humblec commented Mar 15, 2022

Madhu-1 commented Mar 15, 2022

Madhu-1 commented Mar 15, 2022

Madhu-1 commented Mar 15, 2022

Madhu-1 commented Mar 15, 2022

Madhu-1 commented Mar 15, 2022

Madhu-1 commented Mar 15, 2022

Rakshith-R commented Mar 16, 2022

Madhu-1 commented Mar 16, 2022

Madhu-1 commented Mar 16, 2022

Madhu-1 commented Mar 16, 2022

Madhu-1 commented Mar 17, 2022

mergify bot commented Mar 17, 2022

✅ Branch has been successfully rebased

nixpanic commented Mar 20, 2022

mergify bot commented Mar 20, 2022

✅ Branch has been successfully rebased

mergify bot commented Mar 21, 2022

Madhu-1 commented Nov 2, 2022

nixpanic Nov 2, 2022

Choose a reason for hiding this comment

nixpanic Nov 2, 2022

Choose a reason for hiding this comment

nixpanic commented Nov 3, 2022

mergify bot commented Nov 3, 2022

✅ Branch has been successfully rebased

github-actions bot commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

github-actions bot commented Nov 3, 2022

Madhu-1 commented Mar 10, 2022 •

edited

Loading