-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update vendor to latest kubernetes 1.14.0 #299
Conversation
@Madhu-1 its good to move to latest so, |
Should wait for #297 |
added DNM label to avoid accidental merging |
can you send this PR to master branch? from now onwards we will be using master for csiv1.0 development, Thanks |
rebased with master, PTAL |
@leseb @ShyamsundarR PTAL |
@Madhu-1 went through understanding the dependency tree and such, being new to go myself, I have a few questions, which may influence the PR or just be educational for me, hence posting them here to begin with.
|
Discussed the issue in another forum and figured that kubernetes is backward compatible (at least to an extent) and so we should actually be at deps that are 1.13, in an effort to work against v1.13-15. I would hence suggest that this change NOT be done at the moment, as we would still need to support kubernetes v1.13. |
some of the kubernetes independent packages are moved out of the tree to new projects. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
lgtm. thanks ! |
Syncing latest changes from upstream devel for ceph-csi
some of the kubernetes independent packages are moved out of the tree to new projects.
Signed-off-by: Madhu Rajanna madhupr007@gmail.com