rbd: fix bug with missing supported_features #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkalever
force-pushed
the
fix-supportedfile
branch
from
873c646
to
cd66e6e
Compare
Madhu-1
reviewed
Apr 14, 2022
pkalever
force-pushed
the
fix-supportedfile
branch
from
cd66e6e
to
8e27b13
Compare
Madhu-1
reviewed
Apr 14, 2022
nixpanic
changed the title
pkalever
force-pushed
the
fix-supportedfile
branch
from
8e27b13
to
58cf2b8
Compare
pkalever
force-pushed
the
fix-supportedfile
branch
2 times, most recently
from
ccfc0d9
to
9ce561b
Compare
nixpanic
reviewed
Apr 15, 2022
pkalever
force-pushed
the
fix-supportedfile
branch
from
4c5e190
to
5a4d2cf
Compare
pkalever
force-pushed
the
fix-supportedfile
branch
from
5a4d2cf
to
54c350d
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
pkalever
force-pushed
the
fix-supportedfile
branch
from
54c350d
to
fdc15a3
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
pkalever
force-pushed
the
fix-supportedfile
branch
from
fdc15a3
to
b5883f9
Compare
Madhu-1
previously approved these changes
Apr 21, 2022
pkalever
force-pushed
the
fix-supportedfile
branch
from
1a13ebf
to
45d0227
Compare
nixpanic
requested changes
May 13, 2022
internal/rbd/nodeserver.go
Outdated
| if errors.Is(err, os.ErrNotExist) { | ||
| // do not fallback if /sys/bus/rbd/supported_features is absent and we are | ||
| // not in a position to prepare krbd feature attributes | ||
| isFeatureExist = true |
There was a problem hiding this comment.
Still waiting for a reply on this, thanks!
pkalever
force-pushed
the
fix-supportedfile
branch
from
45d0227
to
4e515cc
Compare
pkalever
force-pushed
the
fix-supportedfile
branch
from
4e515cc
to
dbaa00c
Compare
|
@pkalever linter is faililng.. |
humblec
reviewed
May 13, 2022
| librbd.FeatureNameDeepFlatten: { | ||
| needRbdNbd: false, | ||
| }, | ||
| var ( |
There was a problem hiding this comment.
@pkalever can we also document the justifying link as source code comment for below version mapping as referecnce ?
There was a problem hiding this comment.
There is nothing as such, I had to go to linux tree and find it myself :-(
Upstream /sys/bus/rbd/supported_features is part of Linux kernel v4.11.0 Prepare the attributes and use them in case if /sys/bus/rbd/supported_features is missing. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
force-pushed
the
fix-supportedfile
branch
from
dbaa00c
to
ede07ba
Compare
added 2 commits
May 13, 2022 13:18
krbdFeatures is set to zero when kernel version < 3.8, i.e. in case where /sys/bus/rbd/supported_features is absent and we are unable to prepare the krbd attributes based on kernel version. When krbdFeatures is set to zero fallback to NBD only when autofallback is turned ON. Fixes: ceph#2678 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
continue running rbd driver when /sys/bus/rbd/supported_features file is missing, do not bailout. Fixes: ceph#2678 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
force-pushed
the
fix-supportedfile
branch
from
ede07ba
to
87c11b5
Compare
nixpanic
approved these changes
May 13, 2022
|
/restest ci/centos/mini-e2e-helm/k8s-1.21 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.22 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.23 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
humblec
approved these changes
May 13, 2022
yati1998
approved these changes
May 13, 2022
|
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.23 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
2 similar comments
|
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
missing, do not bail out.
Related issues
Fixes: #2678
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results