rbd: consider rbd as default mounter if not set. (backport #3080) #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
yati1998
approved these changes
May 10, 2022
|
Looks like we need #3102 backport to release-3.6 branch also |
commitlint is failing with above error message. |
|
@Mergifyio rebase |
Rakshith-R
approved these changes
May 10, 2022
For the default mounter the mounter option will not be set in the storageclass and as it is not available in the storageclass same will not be set in the volume context, Because of this the mapOptions are getting discarded. If the mounter is not set assuming it's an rbd mounter. Note:- If the mounter is not set in the storageclass we can set it in the volume context explicitly, Doing this check-in node server to support backward existing volumes and the check is minimal we are not altering the volume context. fixes: #3076 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 7067456)
✅ Branch has been successfully rebased |
ceph-csi-bot
force-pushed
the
mergify/bp/release-v3.6/pr-3080
branch
from
1a70fa5
to
27bc30c
Compare
nixpanic
approved these changes
May 10, 2022
|
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.23 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
/retest ci/centos/mini-e2e-helm/k8s-1.23 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
/retest ci/centos/mini-e2e-helm/k8s-1.21 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
/retest ci/centos/mini-e2e-helm/k8s-1.23 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3080 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com