Enable host networking for provisioner #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iceman91176 please check the Commit guidelines to pass the CI. |
iceman91176
force-pushed
the
feat_helm_hostnetworking
branch
2 times, most recently
from
c8f22b5
to
aa49421
Compare
Madhu-1
requested changes
Jun 14, 2022
There was a problem hiding this comment.
@iceman91176 Thanks for the contribution, can you please remove extra commits which is not related to this one.
| @@ -164,6 +164,10 @@ provisioner: | |||
| # system-cluster-critical which is less priority than system-node-critical | |||
| priorityClassName: system-cluster-critical | |||
|
|
|||
| # enable hostnetwork for provisioner pod. default is false | |||
| # useful for deployments where the podNetwork has no access to ceph | |||
| enableHostNetwork: false | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Hm, i don't know where that additional commit came from. I'll take a look at it.
There was a problem hiding this comment.
Did as suggested. Way simpler..
Madhu-1
added
the
component/deployment
iceman91176
force-pushed
the
feat_helm_hostnetworking
branch
from
aa49421
to
c321e0c
Compare
Madhu-1
reviewed
Jun 14, 2022
iceman91176
force-pushed
the
feat_helm_hostnetworking
branch
from
282c875
to
8345995
Compare
|
Well, i performed a dry-run for install and upgrade . That looked good to me. |
Madhu-1
reviewed
Jun 14, 2022
iceman91176
force-pushed
the
feat_helm_hostnetworking
branch
from
8345995
to
fd10eda
Compare
nixpanic
approved these changes
Jun 17, 2022
Madhu-1
approved these changes
Jun 17, 2022
yati1998
approved these changes
Jun 17, 2022
|
@Mergifyio rebase |
Adds the possibility in the helm-chart to enable hostNetworking for provider pods. Signed-off-by: Carsten Buchberger <c.buchberger@witcom.de>
✅ Branch has been successfully rebased |
ceph-csi-bot
force-pushed
the
feat_helm_hostnetworking
branch
from
fd10eda
to
df0b464
Compare
|
/retest ci/centos/mini-e2e/k8s-1.21 |
|
@iceman91176 "ci/centos/mini-e2e/k8s-1.21" test failed. Logs are available at location for debugging |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Adds the possibility in the helm-chart to enable hostNetworking. Useful for cases where the podNetwork has no access to ceph, but the host has.
Is there anything that requires special attention
No ;-)
Related issues
Fixes: #3167
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results