cleanup: create k8s.io/mount-utils Mounter only once #3247
Conversation
| return &rbd.NodeServer{ | ||
| DefaultNodeServer: csicommon.NewDefaultNodeServer(d, t, topology), | ||
| Mounter: mounter, |
There was a problem hiding this comment.
we need this change for rbd right? or else it will panic when we try to access mounter
There was a problem hiding this comment.
no, that should be set by the DefaultNodeServer... not sure why this isn't working as I expected 🤔
Having a look now.
There was a problem hiding this comment.
Dropping the overloading Mounter attribute from rbd.NodeServer should work 🤞
nixpanic
force-pushed
the
cleanup/no-mounter-recreate
branch
from
fdcfc05
to
2828ef0
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
cleanup/no-mounter-recreate
branch
from
2828ef0
to
51e9b43
Compare
|
@Mergifyio rebase |
Recently the k8s.io/mount-utils package added more runtime dectection. When creating a new Mounter, the detect is run every time. This is unfortunate, as it logs a message like the following: ``` mount_linux.go:283] Detected umount with safe 'not mounted' behavior ``` This message might be useful, so it probably good to keep it. In Ceph-CSI there are various locations where Mounter instances are created. Moving that to the DefaultNodeServer type reduces it to a single place. Some utility functions need to accept the additional parameter too, so that has been modified as well. See-also: kubernetes/kubernetes#109676 Signed-off-by: Niels de Vos <ndevos@redhat.com>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
cleanup/no-mounter-recreate
branch
from
51e9b43
to
f2d8a22
Compare
|
/retest ci/centos/mini-e2e/k8s-1.22 |
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
/retest ci/centos/mini-e2e/k8s-1.23 |
|
/retest ci/centos/upgrade-tests-cephfs |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
/retest ci/centos/mini-e2e/k8s-1.23 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
/retest ci/centos/mini-e2e/k8s-1.23 |
|
/retest ci/centos/k8s-e2e-external-storage/1.23 |
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
Recently the k8s.io/mount-utils package added more runtime dectection.
When creating a new Mounter, the detect is run every time. This is
unfortunate, as it logs a message like the following:
This message might be useful, so it probably good to keep it.
In Ceph-CSI there are various locations where Mounter instances are
created. Moving that to the DefaultNodeServer type reduces it to a
single place. Some utility functions need to accept the additional
parameter too, so that has been modified as well.
See-also: kubernetes/kubernetes#109676
Updates: #3246
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results