rbd: remove dummy image workaround #3413
Conversation
|
In case the ceph csi is with this PR/Fix in place and ceph cluster version running is without the https://tracker.ceph.com/issues/53914, this could be a problem , Isnt it ? |
Dont have plan to support those clusters this is not a nice workaround going forward removing it, if someone wants to DR then can use pool mode. |
or use older version of cephcsi |
This fix was backported all the way to octopus. I don't think we need to worry about that case. |
To clarify: pool mode isn't supported with snapshot-based mirroring. But, as I said, just assuming that the fix for https://tracker.ceph.com/issues/53914 is present is fine. |
|
@Mergifyio rebase |
☑️ Nothing to do
|
|
github action are not started on this PR, manually pushing to the PR to get it started |
To address the problem that snapshot schedules are triggered for volumes that are promoted, a dummy image was disabled/enabled for replication. This was done as a workaround, because the promote operation was not triggering the schedules for the image being promoted. The bugs related to the same have been fixed in RBD mirroring functionality and hence the workaround ceph#2656 can be removed from the code base. ceph tracker https://tracker.ceph.com/issues/53914 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Madhu-1
force-pushed
the
remove-dummy-image-workaround
branch
from
09b83e1
to
1736001
Compare
mergify
bot
dismissed stale reviews from Rakshith-R and nixpanic
Pull request has been modified.
That was reported by others at actions/checkout#948 as well. Failures seem to have cleared up now. |
|
/retest all |
|
@Mergifyio refresh |
|
/test all |
✅ Pull request refreshed |
To address the problem that snapshot schedules are triggered for volumes that are promoted, a dummy image was
disabled/enabled for replication. This was done as a workaround, because the promote operation was not triggering the schedules for the image being promoted.
The bugs related to the same have been fixed in RBD mirroring functionality and hence the workaround #2656 can be removed from the code base.
ceph tracker https://tracker.ceph.com/issues/53914
Signed-off-by: Madhu Rajanna madhupr007@gmail.com