ci: install wget for downloading Helm
#3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Oct 12, 2022
In case `wget` is not installed, downloading the Helm release will fail. The `install-helm.sh` script won't return a fatal error in that case, and CI jobs continue running in an environment that is not ready. By adding a check that exist the script with a failure, the CI will now correctly report a problem when Helm can not be downloaded. See-also: ceph#3430 Signed-off-by: Niels de Vos <ndevos@redhat.com>
yati1998
approved these changes
Oct 13, 2022
Madhu-1
approved these changes
Oct 13, 2022
Installing Helm fails if `wget` is not available. The script that installs Helm does not seem to abort though. By installing `wget` in preparation for deploying with Helm, the CI jobs should get ready to run successfully. Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
force-pushed
the
ci/install-wget
branch
from
ad32c2d
to
da60432
Compare
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
In case `wget` is not installed, downloading the Helm release will fail. The `install-helm.sh` script won't return a fatal error in that case, and CI jobs continue running in an environment that is not ready. By adding a check that exist the script with a failure, the CI will now correctly report a problem when Helm can not be downloaded. See-also: #3430 Signed-off-by: Niels de Vos <ndevos@redhat.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
In case `wget` is not installed, downloading the Helm release will fail. The `install-helm.sh` script won't return a fatal error in that case, and CI jobs continue running in an environment that is not ready. By adding a check that exist the script with a failure, the CI will now correctly report a problem when Helm can not be downloaded. See-also: #3430 Signed-off-by: Niels de Vos <ndevos@redhat.com> (cherry picked from commit fa97875)
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2022
In case `wget` is not installed, downloading the Helm release will fail. The `install-helm.sh` script won't return a fatal error in that case, and CI jobs continue running in an environment that is not ready. By adding a check that exist the script with a failure, the CI will now correctly report a problem when Helm can not be downloaded. See-also: #3430 Signed-off-by: Niels de Vos <ndevos@redhat.com> (cherry picked from commit fa97875)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing Helm fails if
wgetis not available. The script that installs Helm does not seem to abort though.By installing
wgetin preparation for deploying with Helm, the CI jobs should get ready to run successfully.Failures look like the following:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results