Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase: x/text: ParseAcceptLanguage takes a long time to parse complex tags #3439

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

nixpanic
Copy link
Member

A vulnerability was found in golang.org/x/text/language package which could cause a denial of service. An attacker can craft an Accept-Language header which ParseAcceptLanguage will take significant time to parse.
Version v0.3.8 of golang.org/x/text fixes a vulnerability.

See-also: https://go.dev/issue/56152
See-also: https://bugzilla.redhat.com/CVE-2022-32149


Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)
  • /retest all: run this in case the CentOS CI failed to start/report any test
    progress or results

@mergify mergify bot added the rebase update the version of an external component label Oct 17, 2022
Madhu-1
Madhu-1 previously approved these changes Oct 17, 2022
@Rakshith-R
Copy link
Contributor

@nixpanic commitlint is failing
✖ header must not be longer than 72 characters, current length is 75 [header-max-length]

@mergify mergify bot dismissed Madhu-1’s stale review October 17, 2022 07:16

Pull request has been modified.

@nixpanic nixpanic requested review from Madhu-1 and a team October 17, 2022 07:16
@nixpanic nixpanic added ci/retry/e2e Label to retry e2e retesting on approved PR's security and removed ci/retry/e2e Label to retry e2e retesting on approved PR's labels Oct 17, 2022
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 17, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2022

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.22

@nixpanic
Copy link
Member Author

/retest ci/centos/k8s-e2e-external-storage/1.23

@nixpanic
Copy link
Member Author

/retest ci/centos/upgrade-tests-cephfs

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 18, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2022

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member Author

@Mergifyio rebase

A vulnerability was found in golang.org/x/text/language package which
could cause a denial of service. An attacker can craft an
Accept-Language header which ParseAcceptLanguage will take significant
time to parse.
Version v0.3.8 of golang.org/x/text fixes a vulnerability.

See-also: https://go.dev/issue/56152
See-also: https://bugzilla.redhat.com/CVE-2022-32149
Signed-off-by: Niels de Vos <ndevos@redhat.com>
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2022

rebase

✅ Branch has been successfully rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/retry/e2e Label to retry e2e retesting on approved PR's rebase update the version of an external component security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants