Update deploy to build canary images for 1.0 #347
Conversation
|
Should be merged once #346 is merged, which would be the final update for 1.0.0 image version. |
|
@phlogistonjohn PTAL, thanks. |
ShyamsundarR
force-pushed
the
stop-image-update
branch
from
dfa4c46 to
dbdef0b
Compare
|
@ShyamsundarR do we really need this PR now ? why I am asking is, we are going or planning to have a |
deploy.sh
Outdated
| elif [ "${TRAVIS_BRANCH}" == 'csi-v1.0' ]; then | ||
| export RBD_IMAGE_VERSION='v1.0.0' | ||
| export CEPHFS_IMAGE_VERSION='v1.0.0' | ||
| export ENV_RBD_IMAGE_VERSION='v1.0.1-canary' |
There was a problem hiding this comment.
AFAIK we agreed to have only canary images tag for csi-v1.0 and also please send a PR to master branch
There was a problem hiding this comment.
We need to stop publishing images from 1.0 branch, what is the strategy for doing that?
Also please update these issues with the same, for users on these branches, #296 #345
The intention here is to have rolling images, such that users can stick to a particular version of the image rather than have the same image updated.
Your strategy seems to be to call master 1.0 and release canary from the same. I think we may need to inform users of this change and proceed, at present there is confusion on the messaging.
ShyamsundarR
force-pushed
the
stop-image-update
branch
from
dbdef0b to
0c6e109
Compare
|
Updated canary tag to 1.0-canary rather than 1.0.1-canary |
ShyamsundarR
changed the title
and hence stop updating the same 1.0.0 image for every PR. At some point we would need to decide how to release, 1.0.1. Signed-off-by: ShyamsundarR <srangana@redhat.com>
ShyamsundarR
force-pushed
the
stop-image-update
branch
from
0c6e109 to
fda3bf3
Compare
Removing DNM as the above is now merged. |
Syncing latest changes from upstream devel for ceph-csi
and hence stop updating the same 1.0.0 image for every PR.
At some point we would need to decide how to release, 1.0.1.
Signed-off-by: ShyamsundarR srangana@redhat.com