Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip]rebase: adopt logging framework change and update to kube 1.26 #3572

Closed
wants to merge 2 commits into from
Closed

[wip]rebase: adopt logging framework change and update to kube 1.26 #3572

wants to merge 2 commits into from

Conversation

humblec
Copy link
Collaborator

@humblec humblec commented Dec 12, 2022 •
edited
Loading

  • This commit update the dependency to 1.26.0 version along with
    other client modules.

  • log framework package is part of core framework with this kube version update.

    Signed-off-by: Humble Chirammal hchiramm@redhat.com

@mergify mergify bot added the rebase update the version of an external component label Dec 12, 2022
@humblec humblec changed the title rebase: adopt logging framework change and update to kube 1.26 [wip]rebase: adopt logging framework change and update to kube 1.26 Dec 12, 2022
@Rakshith-R
Copy link
Contributor

Was the first commit required to get second commit to work ?

The reason for the first commit of e2elog to framework.Log change is not clear to me.
👍 I'll take a look again once it is out of [wip]

@Rakshith-R Rakshith-R removed their request for review December 12, 2022 05:56
@mergify
Copy link
Contributor

mergify bot commented Dec 12, 2022

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@humblec humblec force-pushed the kube-1.26 branch 2 times, most recently from bbd0b34 to 05d1cd7 Compare December 12, 2022 06:26
@Rakshith-R Rakshith-R mentioned this pull request Dec 13, 2022
Closed
@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2022

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@humblec
e2e: account log framework package refactoring
fa94e75 
the logging is part of the core framework and this commit
address the same.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
rebase: update kube dependencies to latest
081a901 
this commit update the kube dependencies.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 13, 2023
@github-actions
Copy link

This pull request has been automatically closed due to inactivity. Please re-open if these changes are still required.

@github-actions github-actions bot closed this Jan 27, 2023
@Madhu-1 Madhu-1 mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rebase update the version of an external component stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humblec @Rakshith-R