Fix error string as per golang standard #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humblec
approved these changes
May 13, 2019
|
I was hoping this would wait for #312 before being pushed, as it enforces the same be fixed in the other PR before a merge. Can it wait? |
|
@humblec PTAL |
Error string should not be capatalized https://github.com/golang/go/wiki/CodeReviewComments#error-strings Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
|
@humblec done |
humblec
approved these changes
Jun 10, 2019
|
Thanks @Madhu-1 |
wilmardo
pushed a commit
to wilmardo/ceph-csi
that referenced
this pull request
Jul 29, 2019
Fix error string as per golang standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error string should not be capatalized
https://github.com/golang/go/wiki/CodeReviewComments#error-strings
Signed-off-by: Madhu Rajanna madhupr007@gmail.com