Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: remove extra check for snapshot count #3735

Merged
merged 1 commit into from
Apr 13, 2023
Merged

e2e: remove extra check for snapshot count #3735

merged 1 commit into from
Apr 13, 2023

Conversation

riya-singhal31
Copy link
Contributor

snapshot count validation has already done for this test, after the deletion of snapshot

@mergify mergify bot added the component/testing Additional test cases or CI work label Apr 4, 2023
@yati1998 yati1998 requested a review from Madhu-1 April 4, 2023 18:43
@Madhu-1 Madhu-1 added the ok-to-test Label to trigger E2E tests label Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/k8s-e2e-external-storage/1.26

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/mini-e2e-helm/k8s-1.23

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/mini-e2e-helm/k8s-1.26

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/mini-e2e/k8s-1.23

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/mini-e2e/k8s-1.26

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

/test ci/centos/upgrade-tests-rbd

@github-actions github-actions bot removed the ok-to-test Label to trigger E2E tests label Apr 5, 2023
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 11, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2023

refresh

✅ Pull request refreshed

@riya-singhal31
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.27

@riya-singhal31
Copy link
Contributor Author

/test ci/centos/mini-e2e-helm/k8s-1.27

@riya-singhal31 riya-singhal31 mentioned this pull request Apr 12, 2023
Merged
@riya-singhal31
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Apr 12, 2023

rebase

❌ Base branch update has failed

riya-singhal31 token is invalid, make sure riya-singhal31 can still log in on the Mergify dashboard.
err-code: E2CFE

@Madhu-1 Madhu-1 added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Apr 13, 2023
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 13, 2023

@Mergifyio rebase

@riya-singhal31 @Madhu-1
e2e: remove extra check for snapshot count
662654b 
snapshot count validation has already done after the deletion
of snapshot

Signed-off-by: riya-singhal31 <rsinghal@redhat.com>
@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2023

rebase

✅ Branch has been successfully rebased

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 13, 2023

Added skipci label as CI already passed on this PR

@Madhu-1 Madhu-1 added the ok-to-test Label to trigger E2E tests label Apr 13, 2023
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.26

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.26

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.26

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@github-actions github-actions bot removed the ok-to-test Label to trigger E2E tests label Apr 13, 2023
@mergify mergify bot merged commit 6f54b88 into ceph:devel Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yati1998 yati1998 yati1998 approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@karthik-us karthik-us karthik-us approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riya-singhal31 @Madhu-1 @karthik-us @yati1998