Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix codespell and shell check failures #3762

Merged
merged 2 commits into from
Apr 20, 2023
Merged

ci: fix codespell and shell check failures #3762

merged 2 commits into from
Apr 20, 2023

Conversation

riya-singhal31
Copy link
Contributor

@riya-singhal31 riya-singhal31 commented Apr 20, 2023 •
edited
Loading

This commit fixes the codespell and shell check ci failure.

@mergify mergify bot added component/testing Additional test cases or CI work bug Something isn't working labels Apr 20, 2023
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 20, 2023

@riya-singhal31 Thanks for the PR can you also fix shell check failures?

@Madhu-1 Madhu-1 added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Apr 20, 2023
@nixpanic
Copy link
Member

Thanks! Do you also want to address the ShellCheck errors with a 2nd commit in this PR?

@Madhu-1 Madhu-1 removed the ci/skip/e2e skip running e2e CI jobs label Apr 20, 2023
@riya-singhal31
Copy link
Contributor Author

Sure, I'll add the fix for shell check failure as well.
Thanks,
@Madhu-1 @nixpanic

@nixpanic nixpanic mentioned this pull request Apr 20, 2023
Merged
@nixpanic nixpanic added the Priority-0 highest priority issue label Apr 20, 2023
@riya-singhal31 riya-singhal31 changed the title ci: fix codespell failure ci: fix codespell and shell check failure Apr 20, 2023
@riya-singhal31 riya-singhal31 changed the title ci: fix codespell and shell check failure ci: fix codespell and shell check failures Apr 20, 2023
@riya-singhal31 riya-singhal31 mentioned this pull request Apr 20, 2023
Merged
@nixpanic nixpanic requested a review from a team April 20, 2023 11:17
@nixpanic
Copy link
Member

@Mergifyio rebase

@riya-singhal31 @nixpanic
ci: fix codespell failure
4131336 
Signed-off-by: riya-singhal31 <rsinghal@redhat.com>
@riya-singhal31 @nixpanic
ci: fix shell check failures
d700d03 
Signed-off-by: riya-singhal31 <rsinghal@redhat.com>
@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Apr 20, 2023
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.26

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.26

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.26

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@github-actions github-actions bot removed the ok-to-test Label to trigger E2E tests label Apr 20, 2023
@riya-singhal31
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.26

@mergify mergify bot merged commit 44612fe into ceph:devel Apr 20, 2023
@riya-singhal31 riya-singhal31 mentioned this pull request Apr 25, 2023
Merged
@Rakshith-R Rakshith-R added the backport-to-release-v3.8 backport to release 3.8 branch label Apr 25, 2023
@Rakshith-R
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
backport-to-release-v3.8 backport to release 3.8 branch bug Something isn't working ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work Priority-0 highest priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riya-singhal31 @Madhu-1 @nixpanic @Rakshith-R