cleanup: set pid limit only for nodeserver #3776
Conversation
Madhu-1
force-pushed
the
cleanup
branch
2 times, most recently
from
063091f
to
4932de3
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| // set pidLimit only for NodeServer | ||
| // the driver may need a higher PID limit for handling all concurrent requests | ||
| if conf.IsNodeServer && conf.PidLimit != 0 { | ||
| currentLimit, pidErr := util.GetPIDLimit() |
There was a problem hiding this comment.
| currentLimit, pidErr := util.GetPIDLimit() | |
| _, pidErr := util.GetPIDLimit() |
currentLimit variable is not used anywhere, let's remove it.
There was a problem hiding this comment.
its used for logging.
nixpanic
added
ci/skip/e2e
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
we dont support imageFormat anymore in cephcsi and default is set to 2, removing its reference from the repo. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
setting pod limit only for nodeserver for below reasons * We dont execute any commands with CLI anymore in controller service * Controller deployment is not privileged enough to set the pid limits. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
setting pod limit only for node server for below reasons
Added one more commit for doc cleanup
Signed-off-by: Madhu Rajanna madhupr007@gmail.com