deploy: add cephfs/CSIDriver and cephfs/csi-config-map to API #3837
Conversation
@riya-singhal31 |
Thanks Rakshith, updated. |
vendor/github.com/ceph/ceph-csi/api/deploy/kubernetes/cephfs/csi-config-map.yaml
Show resolved
Hide resolved
|
|
||
| // NewCSIConfigMap takes a name from the CSIConfigMapValues struct and relaces | ||
| // the value in the template. A ConfigMap object is returned which can be | ||
| // created in the Kubernetes cluster. |
There was a problem hiding this comment.
@riya-singhal31 @nixpanic, what is the value to the end user with this one, we dont have any struct keys inside the configmap as expected by CSI, and we are just returning an empty template for the user, which is of significantly less use.
There was a problem hiding this comment.
if keys are required, then those should probably be documented better. The current example configmap is empty as well?
There was a problem hiding this comment.
Yes it's empty but as you mentioned it's documented and we dont have any documentation for the APIs; this is just returning an empty configmap with a name not sure how much helpful it is.
There was a problem hiding this comment.
The documentation is missing the in the yaml file itself. yaml can have comments, and ideally has them for required options.
If values are required before deploying, the API should offer a way to set them.
There was a problem hiding this comment.
They are required post-deployment but I am still not sure. Just exposing the empty configmap to the user and how it will be useful.
|
|
||
| require.NoError(t, err) | ||
| require.NotEqual(t, "", yaml) | ||
| } |
There was a problem hiding this comment.
new line is missing at the end of the file
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
Signed-off-by: riya-singhal31 <rsinghal@redhat.com>
Signed-off-by: riya-singhal31 <rsinghal@redhat.com>
|
/test ci/centos/k8s-e2e-external-storage/1.24 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.24 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.24 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
Move cephfs/csidriver and cephfs/csi-config-map to API
updates: #3838