Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: install Helm with script located on GitHub #3843

Merged
merged 1 commit into from
May 22, 2023
Merged

ci: install Helm with script located on GitHub #3843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ SNAPSHOT_VERSION=v6.1.0
#TEST_COVERAGE=html
#GO_COVER_DIR=_output/

# URL for the script to install Helm
HELM_SCRIPT=https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using script from main branch is risky, possible to use latest released version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what is recommended in the documentation. I expect that the previous URL pointed to the same version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that it is only used for installing. The version pointed to by HELM_VERSION will be installed and used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a bug in script we will.b3 easily affected as its from main branch, let's handle it in different PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that is needed. Hopefully their main branch is at least as stable as our devel branch.


# helm chart generation, testing and publishing
HELM_VERSION=v3.10.1

Expand Down
2 changes: 1 addition & 1 deletion deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ CSI_CHARTS_DIR=$(mktemp -d)

pushd "${CSI_CHARTS_DIR}" >/dev/null

curl -L https://git.io/get_helm.sh | bash -s -- --version "${HELM_VERSION}"
curl -L "${HELM_SCRIPT}" | bash -s -- --version "${HELM_VERSION}"

build_step "cloning ceph/csi-charts repository"
git clone https://github.com/ceph/csi-charts
Expand Down
2 changes: 1 addition & 1 deletion scripts/Dockerfile.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ RUN source /build.env \
| tar xzf - -C ${GOROOT} --strip-components=1 \
&& curl -sf "https://raw.githubusercontent.com/golangci/golangci-lint/${GOLANGCI_VERSION}/install.sh" \
| bash -s -- -b ${GOPATH}/bin "${GOLANGCI_VERSION}" \
&& curl -L https://git.io/get_helm.sh | bash -s -- --version "${HELM_VERSION}" \
&& curl -L "${HELM_SCRIPT}" | bash -s -- --version "${HELM_VERSION}" \
&& mkdir /opt/commitlint && pushd /opt/commitlint \
&& npm init -y \
&& npm install @commitlint/cli@"${COMMITLINT_VERSION}" \
Expand Down