Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use Go 1.20 as Kubernetes 1.27 requires it #3879

Merged
merged 18 commits into from
Jun 5, 2023
Merged

build: use Go 1.20 as Kubernetes 1.27 requires it #3879

merged 18 commits into from
Jun 5, 2023

Commits on Jun 2, 2023

  1. build: use Go 1.20 

    Kubernetes as a main dependency requires Go 1.20 or newer.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    ae48c60 View commit details
    Browse the repository at this point in the history

  2. ci: update to golangci-lint v1.53.0 

    Version 1.47.3 of golangci-lint does not support Go 1.20, so we'll need
to use a newer version.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    8956e2f View commit details
    Browse the repository at this point in the history

  3. build: address nolintlint errors from new golangci-lint 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    187e727 View commit details
    Browse the repository at this point in the history

  4. ci: disable depguard linter in golangci-lint 

    The `depguard` linter needs additonal configuration, namely a list of
packages that may (not) be imported.

See-also: https://github.com/OpenPeeDeeP/depguard
Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    86834cc View commit details
    Browse the repository at this point in the history

  5. ci: disable gocritic:uncheckedInlineErr due to false-prositives 

    uncheckedInlineErr gives many false-positives, there is no need to
rewrite all of the reported if-statements.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    7d64da8 View commit details
    Browse the repository at this point in the history

  6. build: address gocritic warnings 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    af8a091 View commit details
    Browse the repository at this point in the history

  7. build: address nlreturn warnings 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    ffa66b0 View commit details
    Browse the repository at this point in the history

  8. build: address golint warnings 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    8596d68 View commit details
    Browse the repository at this point in the history

  9. build: address gofmt warnings 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    1817910 View commit details
    Browse the repository at this point in the history

  10. build: address gocritic warnings 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    60074cd View commit details
    Browse the repository at this point in the history

  11. build: address ginkgolinter warnings 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    122e9cb View commit details
    Browse the repository at this point in the history

  12. ci: disable revive:dot-imports 

    The `revive:dot-imports` rule complains about the same problems that
`golint` reports. We only need one `//nolint:golint // ...` comment, not
a second one for revive.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    8420e1e View commit details
    Browse the repository at this point in the history

  13. ci: disable stylecheck:dot-imports 

    The `stylecheck:dot-imports` rule complains about the same problems that
`golint` reports. We only need one `//nolint:golint // ...` comment, not
a second one for stylecheck.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    756d186 View commit details
    Browse the repository at this point in the history

  14. build: address errorlint warning 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    1a4b229 View commit details
    Browse the repository at this point in the history

  15. build: address gosec warning 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    8992db1 View commit details
    Browse the repository at this point in the history

  16. build: address interfacer warning 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    70961d3 View commit details
    Browse the repository at this point in the history

  17. build: address interfacebloat warning for SubVolumeClient 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    e80bc09 View commit details
    Browse the repository at this point in the history

  18. build: address dupword warnings 

    Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    86b1266 View commit details
    Browse the repository at this point in the history