-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CephFS plugin stateless reusing RADOS based journal scheme #390
Conversation
This is a part of the stateless set of commits for CephCSI. This commit removes the dependency on config maps to store cephFS provisioned volumes, and instead relies on RADOS based objects and keys, and required CSI VolumeID encoding to detect the provisioned volumes. Changes: - Provide backward compatibility to provisioned volumes by older plugin versions (1.0.0 or older) - Remove Create/Delete support for statically provisioned volumes (fixes ceph#382) - Added namespace support to RADOS OMaps and used the same to store RADOS CSI objects and keys in the CephFS metadata pool - Added support to mention fsname for CephFS provisioning (fixes ceph#359) - Changed field name in CSI Identifier to 'location', to denote a pool or fscid - Updated mounter cache to use new scheme - Required Helm manifests are updated - Required documentation and other manifests are updated - Made driver option 'metadatastorage' as optional, as fresh installs do not need to specify the same Testing done: - Create/Mount/Delete PVC - Create/Delete 5 PVCs - Mount version 1.0.0 PVC - Delete version 1.0.0 PV - Mount Statically defined PV/PVC/Pod - Mount Statically defined version 1.0.0 PV/PVC/Pod - Delete Statically defined version 1.0.0 PV/PVC/Pod - Node restart when mounted to test mountcache - Use InstanceID other than 'default' - RBD basic round of tests, as namespace is added to OMaps - csitest against ceph-fs plugin - NOTE: CephFS plugin still does not detect and address already created volumes but of a different size - Test not providing any value to the metadata storage parameter Signed-off-by: ShyamsundarR <srangana@redhat.com>
Attention: @ajarr @poornimag For moving forward with #328 and any reviews that can be provided, thanks. |
Please keep in mind that having the ability to mount pre-provisioned volumes with having access only to that particular volume is absolutely crucial for things like shares managed by OpenStack Manila to work. There are cases where the operators may have limited direct access to the ceph cluster.
|
I have already provided the option for static PVs in the I still need to add documentation and possibly example For my testing I used this manifest and should serve as an example to understand if this satisfies your request. For example it avoids monitors in the VolumeContext and uses the ceph-csi-config config map, and should help with changing MONs more easily even for static PVs. @gman0 Thoughts? |
Make CephFS plugin stateless reusing RADOS based journal scheme
Syncing latest changes from devel for ceph-csi
This is a part of the stateless set of commits for CephCSI.
This commit removes the dependency on config maps to store cephFS provisioned
volumes, and instead relies on RADOS based objects and keys, and required
CSI VolumeID encoding to detect the provisioned volumes.
Changes
Testing done
volumes but of a different size
Related issues
Fixes: #382, #359
Implements proposal as stated in #224
Future concerns
Signed-off-by: ShyamsundarR srangana@redhat.com