-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge queue: embarking release-v3.9 (d6d66d5) and #3964 together #3966
Conversation
When a volume has AccessType=Block and is encrypted with LUKS, a resize of the filesystem on the (decrypted) block-device is attempted. This should not be done, as the application that requested the Block volume is the only authoritive reader/writer of the data. In particular VirtualMachines that use RBD volumes as a disk, usually have a partition table on the disk, instead of only a single filesystem. The `resizefs` command will not be able to resize the filesystem on the block-device, as it is a partition table. When `resizefs` fails during NodeStageVolume, the volume is unstaged and an error is returned. Resizing an encrypted block-device requires `cryptsetup resize` so that the LUKS header on the RBD-image is updated with the correct size. But there is no need to call `resizefs` in this case. Fixes: #3945 Signed-off-by: Niels de Vos <ndevos@ibm.com> (cherry picked from commit f60a358)
/test ci/centos/k8s-e2e-external-storage/1.25 |
/test ci/centos/k8s-e2e-external-storage/1.26 |
/test ci/centos/k8s-e2e-external-storage/1.27 |
/test ci/centos/mini-e2e-helm/k8s-1.25 |
/test ci/centos/mini-e2e-helm/k8s-1.26 |
/test ci/centos/mini-e2e-helm/k8s-1.27 |
/test ci/centos/mini-e2e/k8s-1.25 |
/test ci/centos/mini-e2e/k8s-1.26 |
/test ci/centos/mini-e2e/k8s-1.27 |
/test ci/centos/upgrade-tests-cephfs |
/test ci/centos/upgrade-tests-rbd |
✨ Pull request #3964 which was ahead in the queue has been dequeued. ✨
Branch release-v3.9 (d6d66d5) and #3964 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #3964.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
default
for merge:#approved-reviews-by>=1
[🛡 GitHub branch protection]resizefs
on an encrypted BlockMode volume (backport #3958) #3964status-success=ci/centos/k8s-e2e-external-storage/1.25
status-success=ci/centos/k8s-e2e-external-storage/1.26
status-success=ci/centos/k8s-e2e-external-storage/1.27
status-success=ci/centos/mini-e2e-helm/k8s-1.25
status-success=ci/centos/mini-e2e-helm/k8s-1.26
status-success=ci/centos/mini-e2e-helm/k8s-1.27
status-success=ci/centos/mini-e2e/k8s-1.25
status-success=ci/centos/mini-e2e/k8s-1.26
status-success=ci/centos/mini-e2e/k8s-1.27
status-success=ci/centos/upgrade-tests-cephfs
status-success=ci/centos/upgrade-tests-rbd
status-success=codespell
status-success=go-test
status-success=golangci-lint
status-success=lint-extras
status-success=mod-check
status-success=multi-arch-build
base~=^(devel)|(release-.+)$
base=ci/centos
status-success=ci/centos/jjb-validate
status-success=ci/centos/job-validation
#changes-requested-reviews-by=0
[🛡 GitHub branch protection]resizefs
on an encrypted BlockMode volume (backport #3958) #3964Visit the Mergify Dashboard to check the state of the queue
default
.More information about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com