cephfs: add CSI-Addons support to the cephfs #3991
Conversation
| }, | ||
| &identity.Capability{ | ||
| Type: &identity.Capability_ReclaimSpace_{ | ||
| ReclaimSpace: &identity.Capability_ReclaimSpace{ | ||
| Type: identity.Capability_ReclaimSpace_OFFLINE, | ||
| }, | ||
| }, | ||
| }, &identity.Capability{ | ||
| Type: &identity.Capability_NetworkFence_{ | ||
| NetworkFence: &identity.Capability_NetworkFence{ | ||
| Type: identity.Capability_NetworkFence_NETWORK_FENCE, | ||
| }, | ||
| }, | ||
| }, &identity.Capability{ | ||
| Type: &identity.Capability_VolumeReplication_{ | ||
| VolumeReplication: &identity.Capability_VolumeReplication{ | ||
| Type: identity.Capability_VolumeReplication_VOLUME_REPLICATION, | ||
| }, |
There was a problem hiding this comment.
Do we support this for cephfs csi driver?
| Type: &identity.Capability_ReclaimSpace_{ | ||
| ReclaimSpace: &identity.Capability_ReclaimSpace{ | ||
| Type: identity.Capability_ReclaimSpace_ONLINE, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
do we support reclaimspace for cephfs?
|
Thanks for the review Madhu, updated the capabilities supported by cephfs. |
| // setupCSIAddonsServer creates a new CSI-Addons Server on the given (URL) | ||
| // endpoint. The supported CSI-Addons operations get registered as their own | ||
| // services. | ||
| func (fs *Driver) setupCSIAddonsServer(conf *util.Config) error { |
There was a problem hiding this comment.
Looks quite complete to me, but you still need to call this function from the main Run() one somewhere.
There was a problem hiding this comment.
Thanks for the review Niels, just missed it. Updated. PTAL.
|
The below shows that the csi-addons command is running in the csi-addons-sidecar container of a cephfs provisioner pod, as expected. [ndevos@ibm.com ~]$ oc -n openshift-storage rsh -c csi-addons csi-cephfsplugin-jwtfd The following operations are supported: |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d432421 |
this commit adds CSI-Addons support to the cephfs provisioner Signed-off-by: riya-singhal31 <rsinghal@redhat.com>
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
this commit adds CSI-Addons support to the
cephfs provisioner
Updates: #3969