Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Fixing the TODO in createCephfsStorageClass #3995

Merged
merged 1 commit into from
Jul 13, 2023
Merged

e2e: Fixing the TODO in createCephfsStorageClass #3995

merged 1 commit into from
Jul 13, 2023

Conversation

karthik-us
Copy link
Collaborator

Fixing the TODO from createCephfsStorageClass()
since v3.9 is released and upgrade tests will be
run from v3.9 to devel.
#3994

Fixes: #3911

@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels Jul 13, 2023
@karthik-us
Copy link
Collaborator Author

CC @Madhu-1 @Rakshith-R

@karthik-us karthik-us changed the title doc: Fixing the TODO in createCephfsStorageClass e2e: Fixing the TODO in createCephfsStorageClass Jul 13, 2023
@mergify mergify bot added the component/testing Additional test cases or CI work label Jul 13, 2023
Madhu-1
Madhu-1 reviewed Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit message as well.

@Rakshith-R Rakshith-R removed ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels Jul 13, 2023
@Madhu-1 Madhu-1 added the ok-to-test Label to trigger E2E tests label Jul 13, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jul 13, 2023
@nixpanic
Copy link
Member

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge train check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@karthik-us
Copy link
Collaborator Author

Upgrade tests still picked the old version v3.7.2. Maybe due to the test run triggered within few minutes of merging #3994. Re-running to see whether it picks the latest release.

../e2e.test -test.v -ginkgo.timeout="150m" --deploy-timeout="10" --cephcsi-namespace=cephcsi-e2e-14e93bc6 --upgrade-version=v3.7.2 --test-cephfs=false --test-rbd=true --upgrade-testing=true

../e2e.test -test.v -ginkgo.timeout="150m" --deploy-timeout="10" --cephcsi-namespace=cephcsi-e2e-d8d75027 --upgrade-version=v3.7.2 --test-cephfs=true --test-rbd=false --upgrade-testing=true

@karthik-us
Copy link
Collaborator Author

/retest ci/centos/upgrade-tests

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

Upgrade tests still picked the old version v3.7.2. Maybe due to the test run triggered within few minutes of merging #3994. Re-running to see whether it picks the latest release.

../e2e.test -test.v -ginkgo.timeout="150m" --deploy-timeout="10" --cephcsi-namespace=cephcsi-e2e-14e93bc6 --upgrade-version=v3.7.2 --test-cephfs=false --test-rbd=true --upgrade-testing=true

../e2e.test -test.v -ginkgo.timeout="150m" --deploy-timeout="10" --cephcsi-namespace=cephcsi-e2e-d8d75027 --upgrade-version=v3.7.2 --test-cephfs=true --test-rbd=false --upgrade-testing=true

Changes to CI jobs are applied after merging the PR. It can take a few minutes before the updated jobs are available in Jenkins. You can follow the progress at https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/job/jjb-deploy/

@Rakshith-R
Copy link
Contributor

https://github.com/Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@Rakshith-R
Copy link
Contributor

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge train check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@karthik-us
Copy link
Collaborator Author

Changes to CI jobs are applied after merging the PR. It can take a few minutes before the updated jobs are available in Jenkins. You can follow the progress at https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/job/jjb-deploy/

Thanks 👍🏻. Yes the retest run picked the latest version.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jul 13, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jul 13, 2023
@nixpanic nixpanic added the ci/retry/e2e Label to retry e2e retesting on approved PR's label Jul 13, 2023
@ceph-csi-bot
Copy link
Collaborator

/retest ci/centos/mini-e2e-helm/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

@karthik-us "ci/centos/mini-e2e-helm/k8s-1.25" test failed. Logs are available at location for debugging

@ceph-csi-bot
Copy link
Collaborator

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 47b79c8 into ceph:devel Jul 13, 2023
@karthik-us karthik-us deleted the version-upgrade branch July 13, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

Assignees
No one assigned
Labels
ci/retry/e2e Label to retry e2e retesting on approved PR's component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change version for upgrade tests to v3.9.0
5 participants
@karthik-us @ceph-csi-bot @nixpanic @Rakshith-R @Madhu-1