doc: adding empty storageClassName in static pvc #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@subhamkrai you may want to change the prefix of commit heading to doc(no 's'), https://github.com/ceph/ceph-csi/blob/devel/.commitlintrc.yml#L36., else commitlint will fail. |
subhamkrai
force-pushed
the
fix-static-pv-doc
branch
from
ba8c227
to
00cf094
Compare
subhamkrai
changed the title
mergify
bot
added
ci/skip/e2e
|
commitlint failed |
subhamkrai
force-pushed
the
fix-static-pv-doc
branch
from
00cf094
to
0cbfebb
Compare
|
@Mergifyio rebase |
we need to add `storageClassName: ""` in static pvc yaml other we'll get error ``` Cannot bind to requested volume "fs-static-pv": storageClassName does not match ``` Signed-off-by: subhamkrai <srai@redhat.com>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
fix-static-pv-doc
branch
from
0cbfebb
to
c9ce8ef
Compare
nixpanic
approved these changes
Jul 24, 2023
Rakshith-R
approved these changes
Jul 24, 2023
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
Rakshith-R
added a commit
to Rakshith-R/ceph-csi
that referenced
this pull request
Sep 7, 2023
we need to add `storageClassName: ""` in cephfs static pvc similar what was done for rbd static pvc in ceph#4010. Signed-off-by: Rakshith R <rar@redhat.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
we need to add `storageClassName: ""` in cephfs static pvc similar what was done for rbd static pvc in #4010. Signed-off-by: Rakshith R <rar@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/ceph-csi
that referenced
this pull request
Oct 11, 2023
we need to add `storageClassName: ""` in cephfs static pvc similar what was done for rbd static pvc in ceph#4010. Signed-off-by: Rakshith R <rar@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
we need to add
storageClassName: ""in static pvc yaml other we'll get errorIs there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:
Kubernetes links that explain why the change is required
https://kubernetes.io/docs/concepts/storage/persistent-volumes/#class-1
CSI spec related changes/catch-up that necessitates this patch
golang related practices that necessitates this change
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)