Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: remove subvolume during clone #4223

Merged
merged 2 commits into from
Nov 8, 2023
Merged

cephfs: remove subvolume during clone #4223

merged 2 commits into from
Nov 8, 2023

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Nov 2, 2023

If any operations like resizing or deleting the snapshot fail, we need to remove both the snapshot and the clone to avoid resource leaks.

closes: #4218

@Madhu-1 Madhu-1 requested review from nixpanic, iPraveenParihar and a team November 2, 2023 10:52
@mergify mergify bot added the component/cephfs Issues related to CephFS label Nov 2, 2023
nixpanic
nixpanic previously approved these changes Nov 2, 2023
View reviewed changes
riya-singhal31
riya-singhal31 previously approved these changes Nov 3, 2023
View reviewed changes
@nixpanic
Copy link
Member

nixpanic commented Nov 3, 2023

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 3, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

nixpanic commented Nov 3, 2023

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 3, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Nov 3, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 3, 2023
@riya-singhal31
Copy link
Contributor

/test ci/centos/mini-e2e/k8s-1.28

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 6, 2023

/test ci/centos/mini-e2e/k8s-1.28

@mergify mergify bot dismissed nixpanic’s stale review November 6, 2023 07:36

Pull request has been modified.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 6, 2023

/test ci/centos/mini-e2e/k8s-1.28

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 8, 2023

@Mergifyio rebase

@Madhu-1
cephfs: remove subvolume during clone
58feb6f 
If any operations like Resize, Deleting
snapshot fails, we need to remove
both snapshot and the clone to avoid
resource leak.

closes: ceph#4218

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1
cephfs: avoid variable shadowing
cadcb5a 
Avoiding variable shadowing as it
becomes hard to debug this kind of
issues in real enviroment.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2023

rebase

✅ Branch has been successfully rebased

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 8, 2023

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2023 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Nov 8, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 8, 2023
@nixpanic
Copy link
Member

nixpanic commented Nov 8, 2023

/retest ci/centos/mini-e2e-helm/k8s-1.26

@nixpanic
Copy link
Member

nixpanic commented Nov 8, 2023

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2023 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1b39b82

@mergify mergify bot merged commit 1b39b82 into ceph:devel Nov 8, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@nixpanic nixpanic Awaiting requested review from nixpanic

Assignees
No one assigned
Labels
component/cephfs Issues related to CephFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the clone and the snapshot if Expand/DeleteSnapshot fails.
6 participants
@Madhu-1 @nixpanic @ceph-csi-bot @riya-singhal31 @iPraveenParihar @Rakshith-R