CephFS: Update fetchIP() to add support for IPv6 address #4230
Conversation
riya-singhal31
changed the title
| ip := strings.Split(parts[1], ":")[0] | ||
|
|
||
| return ip, nil | ||
| // use a regular expression to find an IPv4 or IPv6 address in the string |
There was a problem hiding this comment.
you can use net.ParseIP to find the IP address from string https://go.dev/play/p/PSqKE6XxZtO
There was a problem hiding this comment.
Thanks @Madhu-1 for sharing, updated the code with net.ParseIP and a few additional parsing as the expected format of clientInfo is "inst": "client.4305 172.21.9.34:0/422650892"
PTAL
| @@ -68,6 +68,11 @@ func TestFetchIP(t *testing.T) { | |||
| expectedIP: "172.21.9.34", | |||
| expectedErr: false, | |||
| }, | |||
| { | |||
| clientInfo: "client.4305 2001:0db8:85a3:0000:0000:8a2e:0370:7334:0/422650892", | |||
There was a problem hiding this comment.
How did you confirm that Ceph uses this format with IPv6 addresses?
There was a problem hiding this comment.
From the official documentation of ceph
As the inst listed in ceph tell mds.0 client ls for the IPv4 address,
'"inst": "client.4305 172.21.9.34:0/422650892",
So IPv6 should also be the same only like the client id and then..
I'll check with ceph for more clarity on this.
There was a problem hiding this comment.
Checked with Xiubo and Kotresh, the given syntax is fine!
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
@Mergifyio rebase |
Signed-off-by: Riya Singhal <rsinghal@redhat.com>
Signed-off-by: Riya Singhal <rsinghal@redhat.com>
✅ Branch has been successfully rebased |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 2598300 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
Madhu-1
added
ci/skip/e2e
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
the current fetchIP() function works for IPv4 addresses, this commit updates the same to support IPv6 too.
fixes: #4192