Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy: added json field tags for csi config map #4329

Merged
merged 1 commit into from
Dec 21, 2023
Merged

deploy: added json field tags for csi config map #4329

merged 1 commit into from
Dec 21, 2023

Conversation

iPraveenParihar
Copy link
Contributor

@iPraveenParihar iPraveenParihar commented Dec 19, 2023 •
edited
Loading

Describe what this PR does

This commit adds the json field tags for csi config map for encoding and decoding JSON.
missed in #4278

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar iPraveenParihar marked this pull request as ready for review December 19, 2023 10:54
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.28

@Rakshith-R
Copy link
Contributor

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2023

rebase

✅ Branch has been successfully rebased

Rakshith-R
Rakshith-R approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Rakshith-R Rakshith-R requested review from nixpanic and a team December 21, 2023 09:03
@nixpanic
Copy link
Member

Could you explain why this is needed? If it is required, why was there no failure in a CI job? Can you make sure that this is now tested well, and if someone modified the code, the test catches it?

@iPraveenParihar
Copy link
Contributor Author

Could you explain why this is needed? If it is required, why was there no failure in a CI job? Can you make sure that this is now tested well, and if someone modified the code, the test catches it?

Yes, my bad
I created the struct in #4278 but forgot to use in that pr.

@nixpanic
Copy link
Member

@Mergifyio rebase

@iPraveenParihar @nixpanic
deploy: added json field tags for csi config map
d9d53b1 
This commit adds the json field tags for csi config map for
encoding and decoding JSON.

Signed-off-by: Praveen M <m.praveen@ibm.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 21, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 21, 2023 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 50e5056

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Dec 21, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 21, 2023
@mergify mergify bot merged commit 50e5056 into ceph:devel Dec 21, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iPraveenParihar @Rakshith-R @nixpanic @ceph-csi-bot