Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use Go 1.21.5 #4332

Merged
merged 3 commits into from
Dec 19, 2023
Merged

build: use Go 1.21.5 #4332

merged 3 commits into from
Dec 19, 2023

Conversation

nixpanic
Copy link
Member

The package k8s.io/kubernetes/pkg/features requires Go 1.21 now, so
let's use that while building.

Signed-off-by: Niels de Vos ndevos@ibm.com

@mergify mergify bot added the component/build Issues and PRs related to compiling Ceph-CSI label Dec 19, 2023
Rakshith-R
Rakshith-R previously approved these changes Dec 19, 2023
The package k8s.io/kubernetes/pkg/features requires Go 1.21 now, so
let's use that while building.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
Sometimes the Ceph container images seem to have a broken scriptlet
while installing/updating Ceph packages. It is relatively common for
them to fail when `/etc/selinux/config` does not exist. By ensuring the
file directory and file exist (even if empty), the package installation
or upgrades succeed.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@mergify mergify bot dismissed Rakshith-R’s stale review December 19, 2023 09:08

Pull request has been modified.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic nixpanic requested review from Rakshith-R and a team December 19, 2023 10:28
Copy link
Contributor

@riya-singhal31 riya-singhal31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Dec 19, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build Issues and PRs related to compiling Ceph-CSI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants