Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy: update CSI sidecars to latest versions available #4420

Merged
merged 1 commit into from
Feb 10, 2024
Merged

deploy: update CSI sidecars to latest versions available #4420

merged 1 commit into from
Feb 10, 2024

Conversation

iPraveenParihar
Copy link
Contributor

Describe what this PR does

Below sidecars are updated with latest available versions

csi-node-driver-registrar: v2.10.0
csi-resizer: v1.10.0
csi-provisioner: v4.0.0
csi-attacher: v4.5.0
csi-snapshotter: v7.0.0

Related issues

Fixes: #4419

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-helm/k8s-1.28

@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.26

@iPraveenParihar iPraveenParihar marked this pull request as ready for review February 7, 2024 15:14
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/upgrade-tests-cephfs

@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/upgrade-tests-rbd

@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/k8s-e2e-external-storage/1.26

@iPraveenParihar iPraveenParihar self-assigned this Feb 7, 2024
Madhu-1
Madhu-1 reviewed Feb 8, 2024
View reviewed changes
build.env
CSI_ATTACHER_VERSION=v4.5.0
CSI_SNAPSHOTTER_VERSION=v7.0.0
CSI_RESIZER_VERSION=v1.10.0
CSI_PROVISIONER_VERSION=v4.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check if any new RBAC changes are required for any new features as some of them are major releases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check if any new RBAC changes are required for any new features as some of them are major releases?

Checked, there are no RBAC changes required.

@iPraveenParihar
Copy link
Contributor Author

@Madhu-1,
Now with latest provisioner we have prevent-volume-mode-conversion feature flag enabled by default.
we have it enabled explicitly, can we remove it?

ceph-csi/deploy/rbd/kubernetes/csi-rbdplugin-provisioner.yaml

Lines 58 to 60 in 141928d

- "--feature-gates=Topology=false"
- "--feature-gates=HonorPVReclaimPolicy=true"
- "--prevent-volume-mode-conversion=true"

@nixpanic
Copy link
Member

nixpanic commented Feb 8, 2024

@Madhu-1, Now with latest provisioner we have prevent-volume-mode-conversion feature flag enabled by default. we have it enabled explicitly, can we remove it?

ceph-csi/deploy/rbd/kubernetes/csi-rbdplugin-provisioner.yaml

Lines 58 to 60 in 141928d

- "--feature-gates=Topology=false"
- "--feature-gates=HonorPVReclaimPolicy=true"
- "--prevent-volume-mode-conversion=true"

I think it makes sense to keep it as it is for now. In the future we may want to enable it for backup applications that use the workflow described in the last section of this Motivation.

@Madhu-1 Madhu-1 requested a review from nixpanic February 9, 2024 07:25
@nixpanic
Copy link
Member

nixpanic commented Feb 9, 2024

This can be queued for merging once #4422 is finished with CI.

@nixpanic
Copy link
Member

nixpanic commented Feb 9, 2024

@Mergifyio rebase

@iPraveenParihar @nixpanic
deploy: update CSI sidecars to latest versions available
2f86c96 
Below sidecars are updated with latest available versions

csi-node-driver-registrar: v2.10.0
csi-resizer: v1.10.0
csi-provisioner: v4.0.0
csi-attacher: v4.5.0
csi-snapshotter: v7.0.0

Signed-off-by: Praveen M <m.praveen@ibm.com>
@nixpanic nixpanic force-pushed the update-csi-sidecars-to-latest branch from afa11a9 to 2f86c96 Compare February 9, 2024 13:22
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 9, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

nixpanic commented Feb 9, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 9, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Feb 9, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Feb 9, 2024
@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e-helm/k8s-1.26

@iPraveenParihar
Copy link
Contributor Author

iPraveenParihar commented Feb 10, 2024 •
edited
Loading

/retest ci/centos/mini-e2e/k8s-1.26

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e/k8s-1.28

@iPraveenParihar
Copy link
Contributor Author

/retest ci/centos/mini-e2e/k8s-1.26

@mergify mergify bot merged commit fc6d34a into ceph:devel Feb 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees

@iPraveenParihar iPraveenParihar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update csi sidecars to the latest available versions
4 participants
@iPraveenParihar @nixpanic @ceph-csi-bot @Madhu-1