ci: update install-snapshot script to deploy newer version of snapshotter #4438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating csi snapshotter deployment to pull image and rbac from latest released version. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
Madhu-1
added
the
ci/skip/multi-arch-build
nixpanic
reviewed
Feb 15, 2024
scripts/install-snapshot.sh
Outdated
| echo "Argument already present and matching." | ||
| else | ||
| # Add the argument if it's not present | ||
| sed -i -E "/^(\s+)args:/a\ \ \ \ \ \ \ \ \ \ \ \ - $ARGUMENT" "${temp_snap_controller}" |
There was a problem hiding this comment.
wow, do you really need to add the \ before each space?
There was a problem hiding this comment.
not required but works, updated to remove extra \ :D
Install latest version of snapshotter and also take care of create/delete of new CRD's and required flag for volumegroupsnapshot operation Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
remove unused function from the install-snapshot script Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
canary tag is no more used in the snapshotter yaml and latest version are used, instead of searching for tag check for the image name and do sed to replace the required tag only. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
use kubectl_retry helper to avoid intermediate failure and retry again Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
with new release of snapshotter the labels are changed, this commit uses the new labels to list the snapshot controller pod. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
nixpanic
approved these changes
Feb 15, 2024
riya-singhal31
approved these changes
Feb 15, 2024
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 0a82f17 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
install-snapshot.shto support installing of new snapshotter version and also to enable volumegroupsnapshot flag during installation. Usedkubectl_retryhelper to retry if there is any failure.updates #4435