Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fscrypt: create a new blank key sized according to the passphrase #4464

Merged
merged 2 commits into from
Mar 6, 2024
Merged

fscrypt: create a new blank key sized according to the passphrase #4464

merged 2 commits into from
Mar 6, 2024

Commits on Mar 6, 2024

  1. cephfs: return ErrBadAuth during keyFn retry 

    fscrypt will infinitely retry the keyFn during an auth failure,
preventing the csi driver from progressing when configured with
an invalid passphrase

See also:
https://github.com/google/fscrypt/blob/8c12cd64ab471d0a73ef4c300d7c40077cad5d5d/actions/callback.go#L102-L106

Signed-off-by: Michael Fritch <mfritch@suse.com>
    @mgfritch @nixpanic
    mgfritch authored and nixpanic committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    ab67686 View commit details
    Browse the repository at this point in the history

  2. cephfs: create a new blank key sized according to the passphrase 

    Padding a passphrase with null chars to arrive at a 32-byte length
later forces a user to also pass null chars via the term when
attempting to manually unlock a subvolume via the fscrypt cli tools.

This also had a side-effect of truncating any longer length passphrase
down to a shorter 32-byte length.

fixup for:
cfea8d7
dd0e198

Signed-off-by: Michael Fritch <mfritch@suse.com>
    @mgfritch @nixpanic
    mgfritch authored and nixpanic committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    af0479a View commit details
    Browse the repository at this point in the history