Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: correct typo in NewCSIVolumeroupJournal() function #4495

Merged
merged 1 commit into from
Mar 15, 2024
Merged

cleanup: correct typo in NewCSIVolumeroupJournal() function #4495

merged 1 commit into from
Mar 15, 2024

Conversation

nixpanic
Copy link
Member

The name of the function should be NewCSIVolumeGroupJournal().

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@nixpanic nixpanic added the ci/skip/e2e skip running e2e CI jobs label Mar 14, 2024
@nixpanic nixpanic requested review from Madhu-1 and a team March 14, 2024 08:28
@mergify mergify bot added the cleanup label Mar 14, 2024
Rakshith-R
Rakshith-R previously approved these changes Mar 14, 2024
View reviewed changes
Madhu-1
Madhu-1 previously approved these changes Mar 14, 2024
View reviewed changes
@nixpanic
Copy link
Member Author

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 14, 2024

rebase

✅ Nothing to do for rebase action

@nixpanic
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 14, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The pull request #4495 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic nixpanic force-pushed the cleanup/NewCSIVolumeGroupJournal branch from 5657875 to a1bd747 Compare March 14, 2024 09:27
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Mar 14, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 14, 2024
@nixpanic nixpanic force-pushed the cleanup/NewCSIVolumeGroupJournal branch from a1bd747 to bb1c3bf Compare March 14, 2024 09:46
@mergify mergify bot dismissed stale reviews from iPraveenParihar, Rakshith-R, and Madhu-1 March 14, 2024 09:46

Pull request has been modified.

@nixpanic
Copy link
Member Author

Argh, pushed to the wrong branch 😭

@nixpanic nixpanic force-pushed the cleanup/NewCSIVolumeGroupJournal branch from bb1c3bf to 6942648 Compare March 14, 2024 09:50
@mergify mergify bot mentioned this pull request Mar 14, 2024
Merged
@nixpanic
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 15, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at c32dfc0

@nixpanic
cleanup: correct typo in NewCSIVolumeroupJournal() function
fb6df78 
The name of the function should be `NewCSIVolumeGroupJournal()`.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic nixpanic force-pushed the cleanup/NewCSIVolumeGroupJournal branch from 6942648 to fb6df78 Compare March 15, 2024 10:40
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Mar 15, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 15, 2024
@mergify mergify bot merged commit c32dfc0 into ceph:devel Mar 15, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nixpanic @ceph-csi-bot @Madhu-1 @iPraveenParihar @Rakshith-R