Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: rename EncryptionTypeString() to EncryptionType.String() #4525

Merged
merged 1 commit into from
Apr 2, 2024
Merged

cleanup: rename EncryptionTypeString() to EncryptionType.String() #4525

merged 1 commit into from
Apr 2, 2024

Conversation

nixpanic
Copy link
Member

This makes it easier to log the EncryptionType as string, or int,
whatever is preferred. Standard fmt formatting notations like %s or %d
can be used now.

@mergify mergify bot added the cleanup label Mar 29, 2024
@nixpanic
Copy link
Member Author

nixpanic commented Apr 1, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 1, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic nixpanic force-pushed the cleanup/EncryptionTypeString branch from aaf04dc to b50fe89 Compare April 1, 2024 19:40
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Apr 1, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Apr 1, 2024
@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2024

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2024

rebase

✅ Nothing to do for rebase action

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2024

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
cleanup: rename EncryptionTypeString() to EncryptionType.String()
a1859e8 
This makes it easier to log the EncryptionType as string, or int,
whatever is preferred. Standard fmt formatting notations like %s or %d
can be used now.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic nixpanic force-pushed the cleanup/EncryptionTypeString branch from b50fe89 to a1859e8 Compare April 2, 2024 11:33
@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2024

refresh

✅ Pull request refreshed

@nixpanic
Copy link
Member Author

nixpanic commented Apr 2, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 86b5db9

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Apr 2, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Apr 2, 2024
@mergify mergify bot merged commit 86b5db9 into ceph:devel Apr 2, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@yati1998 yati1998 yati1998 approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nixpanic @ceph-csi-bot @yati1998 @Rakshith-R