Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: do not require Kubernetes 1.26 tests for the devel branch #4578

Merged
merged 1 commit into from
Apr 24, 2024
Merged

ci: do not require Kubernetes 1.26 tests for the devel branch #4578

merged 1 commit into from
Apr 24, 2024

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Apr 23, 2024 •
edited
Loading

Kubernetes 1.26 is End-Of-Life, the next version of Ceph-CSI will not
support that anymore.

@nixpanic nixpanic requested a review from a team April 23, 2024 11:38
@mergify mergify bot added the component/testing Additional test cases or CI work label Apr 23, 2024
@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Apr 23, 2024
Rakshith-R
Rakshith-R reviewed Apr 24, 2024
View reviewed changes
.mergify.yml Outdated
@@ -67,25 +64,6 @@ queue_rules:
- "status-success=ci/centos/mini-e2e/k8s-1.28"
- "status-success=ci/centos/upgrade-tests-cephfs"
- "status-success=ci/centos/upgrade-tests-rbd"
- and:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this ?
We'll need to re add when k8s test versions differs between devel and release branches?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do that when there is a need. Currently things (rules to queue, rules to merge) are not in-sync, this PR corrects that too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nixpanic we need to readd everything in that case,. keep as its and remove 1.26 from devel for sure and if we are not planning to run that on release-3.11 we can drop it from above section. lets not remove the entire section for devel.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I've added the rule for the devel branch in that case, so that everything is the same everywhere.

@nixpanic nixpanic requested a review from Madhu-1 April 24, 2024 07:51
@iPraveenParihar
Copy link
Contributor

@nixpanic,
can we drop 1.26 for v3.11.0?

ceph-csi/README.md

Lines 57 to 62 in 4b49d28

| Ceph CSI Version | Container Orchestrator Name | Version Tested |
| -----------------| --------------------------- | -------------------|
| v3.11.0 | Kubernetes | v1.26, v1.27, v1.28, v1.29|
| v3.10.2 | Kubernetes | v1.26, v1.27, v1.28|
| v3.10.1 | Kubernetes | v1.26, v1.27, v1.28|
| v3.10.0 | Kubernetes | v1.26, v1.27, v1.28|

@Rakshith-R
Copy link
Contributor

@nixpanic, can we drop 1.26 for v3.11.0?

ceph-csi/README.md

Lines 57 to 62 in 4b49d28

| Ceph CSI Version | Container Orchestrator Name | Version Tested |
| -----------------| --------------------------- | -------------------|
| v3.11.0 | Kubernetes | v1.26, v1.27, v1.28, v1.29|
| v3.10.2 | Kubernetes | v1.26, v1.27, v1.28|
| v3.10.1 | Kubernetes | v1.26, v1.27, v1.28|
| v3.10.0 | Kubernetes | v1.26, v1.27, v1.28|

That release is already out, I think we can remove it for 3.11.1 when it happens

@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 2887747

@nixpanic
ci: do not require Kubernetes 1.26 tests for the devel branch
1971f9e 
Kubernetes 1.26 is End-Of-Life, the next version of Ceph-CSI will not
support that anymore.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Apr 24, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Apr 24, 2024
@mergify mergify bot merged commit 2887747 into ceph:devel Apr 24, 2024
36 checks passed
@nixpanic nixpanic deleted the mergify/k8s/remove-v1.26 branch June 6, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nixpanic @iPraveenParihar @Rakshith-R @ceph-csi-bot @Madhu-1