[WIP] rbd: add additional space for encrypted volumes #4582
+205
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
minikube testing, Created a 1GiB block-mode pvc, and then expanded to 2GiB |
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
from
b7586df
to
850dd3a
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
from
850dd3a
to
357a727
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
4 times, most recently
from
29e4f91
to
4f0f3fc
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
@Mergifyio rebase This causes a run of the GitHub CI jobs. Logs for ci/centos/mini-e2e-helm/k8s-1.28 show that e2e passed earlier. |
nixpanic
force-pushed
the
rbd/configure-encrpted-vol-size
branch
from
4f0f3fc
to
69aeda7
Compare
✅ Branch has been successfully rebased |
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
2 times, most recently
from
227bcf0
to
a4eabb3
Compare
|
/test ci/centos/mini-e2e/k8s-1.28 |
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
5 times, most recently
from
7b79d41
to
ca95618
Compare
|
/test ci/centos/mini-e2e/k8s-1.29/test_type-rbd |
|
/test ci/centos/mini-e2e/k8s-1.29 |
@karthik-us, is this the correct command to run |
|
/test ci/centos/mini-e2e/k8s-1.29 |
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
from
ca95618
to
72252c7
Compare
|
/test ci/centos/mini-e2e/k8s-1.29 |
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
from
72252c7
to
9d52790
Compare
Madhu-1
requested changes
May 6, 2024
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
from
9d52790
to
b8c9e50
Compare
|
/test ci/centos/mini-e2e/k8s-1.29 |
Madhu-1
reviewed
May 6, 2024
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
3 times, most recently
from
624153c
to
d756a9d
Compare
|
/test ci/centos/mini-e2e/k8s-1.29 |
Rakshith-R
reviewed
May 7, 2024
Madhu-1
reviewed
May 7, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
iPraveenParihar
changed the title
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
from
d756a9d
to
de7dc06
Compare
issue: when a block-mode pvc is created with encryption enabled there is some space reserved for the encryption metadata. Which doesn't allows users to write extact amount of data that they have requested for. solution: create pvc with extra space needed for the encryption metadata. `GetLuksHeaderSize()` function returns the luks2 encryption metadata(header size). The extra space is added during the CreateVolume and ExpandVolume operations. And while returning the response remove the extra space so the client/user gets the requested size reported. Signed-off-by: Praveen M <m.praveen@ibm.com>
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
from
de7dc06
to
2c82ef6
Compare
|
/test ci/centos/mini-e2e/k8s-1.29 |
1 similar comment
|
/test ci/centos/mini-e2e/k8s-1.29 |
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
2 times, most recently
from
f9d3bd5
to
267715e
Compare
|
/test ci/centos/mini-e2e/k8s-1.29 |
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
from
267715e
to
38a71b5
Compare
|
/test ci/centos/mini-e2e/k8s-1.29 |
This commit adds testcase for the create/resize/clone/restore operations for a RBD block PVC and validate imageSize and deviceSize. Signed-off-by: Praveen M <m.praveen@ibm.com>
iPraveenParihar
force-pushed
the
rbd/configure-encrpted-vol-size
branch
from
38a71b5
to
bc141c1
Compare
|
/test ci/centos/mini-e2e/k8s-1.29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
rbd: add additional space for encrypted volumes
issue: when a block-mode pvc is created with encryption enabled
there is some space reserved for the encryption metadata.
Which doesn't allows users to write extact amount of data that
they have requested for.
solution: create pvc with extra space needed for the encryption
metadata.
GetLuksHeaderSize()function returns the luks2encryption metadata(header size).
The extra space is added during the CreateVolume and ExpandVolume
operations. And while returning the response remove the extra space
so the client/user gets the requested size reported.
Test result:
{ "name": "csi-vol-ca2d5f5c-0da5-4107-a4e0-d0b28eba94cc", "id": "b5f4e403bfe5e", "size": 1090519040, // 1GiB + 16MiB "objects": 260, "order": 22, "object_size": 4194304, "snapshot_count": 0, "block_name_prefix": "rbd_data.b5f4e403bfe5e", "format": 2, "features": [ "layering", "operations" ], "op_features": [ "clone-child" ], "flags": [], "create_timestamp": "Thu Jun 13 07:07:12 2024", "access_timestamp": "Thu Jun 13 07:07:12 2024", "modify_timestamp": "Thu Jun 13 07:07:12 2024", "parent": { "pool": "replicapool", "pool_namespace": "", "image": "csi-vol-ca2d5f5c-0da5-4107-a4e0-d0b28eba94cc-temp", "id": "b5f4e6e333281", "snapshot": "a8a490a0-3237-48d6-bcaa-859f0aad6ea1", "trash": false, "overlap": 1073741824 // parent size - 1GiB } }{ "name": "csi-vol-5b4e7457-eb17-454a-a734-394cf27e7e84", "id": "b5f4e2b8beacc", "size": 1090519040, // 1GiB + 16MiB "objects": 260, "order": 22, "object_size": 4194304, "snapshot_count": 0, "block_name_prefix": "rbd_data.b5f4e2b8beacc", "format": 2, "features": [ "layering", "operations" ], "op_features": [ "clone-child" ], "flags": [], "create_timestamp": "Thu Jun 13 07:11:16 2024", "access_timestamp": "Thu Jun 13 07:11:16 2024", "modify_timestamp": "Thu Jun 13 07:11:16 2024", "parent": { "pool": "replicapool", "pool_namespace": "", "image": "csi-vol-5b4e7457-eb17-454a-a734-394cf27e7e84-temp", "id": "b5f4e6517ad39", "snapshot": "479b9d82-7044-4597-8316-f7e67bc793f5", "trash": false, "overlap": 1090519040 // parent size - 1GiB + 16MiB } }{ "name": "csi-vol-8991734d-9d89-47fb-b157-6308fb35d540", "id": "b5f056ad8db76", "size": 2164260864, // 2GiB + 16MiB "objects": 516, "order": 22, "object_size": 4194304, "snapshot_count": 0, "block_name_prefix": "rbd_data.b5f056ad8db76", "format": 2, "features": [ "layering" ], "op_features": [], "flags": [], "create_timestamp": "Thu Jun 13 06:44:03 2024", "access_timestamp": "Thu Jun 13 06:44:03 2024", "modify_timestamp": "Thu Jun 13 06:44:03 2024" }{ "name": "csi-vol-00d3a9ff-a76b-4f38-a463-5686478b4347", "id": "b5f4e4f96b175", "size": 2164260864, // 2GiB + 16MiB "objects": 516, "order": 22, "object_size": 4194304, "snapshot_count": 1, "block_name_prefix": "rbd_data.b5f4e4f96b175", "format": 2, "features": [ "layering", "operations" ], "op_features": [ "clone-parent", "snap-trash" ], "flags": [], "create_timestamp": "Thu Jun 13 06:47:56 2024", "access_timestamp": "Thu Jun 13 06:47:56 2024", "modify_timestamp": "Thu Jun 13 06:47:56 2024" }$ k exec rbd-pod-e -- blockdev --getsize64 /dev/xvda 2147483648Related issues
Fixes: #issue_number
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)