Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use temporary directory for unit tests #4626

Merged
merged 1 commit into from
May 27, 2024
Merged

ci: Use temporary directory for unit tests #4626

merged 1 commit into from
May 27, 2024

Conversation

mayankpall
Copy link
Contributor

@mayankpall mayankpall commented May 18, 2024 •
edited
Loading

ci: Use temporary directory for unit tests

This commit implements the use of a temporary directory for unit tests in order to ensure a clean and isolated environment for testing purposes.

Signed-off-by: Mayank Pal mayankpal9654@gmail.com

Fixes #4617

@mergify mergify bot added the component/testing Additional test cases or CI work label May 18, 2024
@mayankpall
Copy link
Contributor Author

@iPraveenParihar Hopefully now it meets the requirement

@iPraveenParihar
Copy link
Contributor

@iPraveenParihar Hopefully now it meets the requirement

@mayankpall, please look at the following error and update the commit body.

✖ body's lines must not be longer than 80 characters [body-max-line-length]

@mayankpall
Copy link
Contributor Author

mayankpall commented May 19, 2024 •
edited
Loading

Screenshot 2024-05-19 at 4 45 26 PM

@iPraveenParihar edited it to shortest as possible.

@mayankpall
Copy link
Contributor Author

@iPraveenParihar all checks have passed

Madhu-1
Madhu-1 requested changes May 21, 2024
View reviewed changes
internal/rbd/nodeserver_test.go Outdated Show resolved Hide resolved
@mergify mergify bot dismissed iPraveenParihar’s stale review May 21, 2024 10:15

Pull request has been modified.

@mayankpall
Copy link
Contributor Author

@Madhu-1 removed err = os.Mkdir("/etc/ceph-csi-config", 0o600)

Madhu-1
Madhu-1 requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all the commits into a single commit.

internal/rbd/nodeserver_test.go Outdated Show resolved Hide resolved
@mayankpall
Copy link
Contributor Author

@Madhu-1 removed and squashed all the commits

@iPraveenParihar
Copy link
Contributor

@Madhu-1, can we skip e2e tests for this PR? Since changes are in unit tests?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 21, 2024

@Madhu-1, can we skip e2e tests for this PR? Since changes are in unit tests?

yes that make sense, we can skip multi-arch buil and E2E for this kind of PR's

@Madhu-1 Madhu-1 added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels May 21, 2024
@iPraveenParihar
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@iPraveenParihar
Copy link
Contributor

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

rebase

✅ Branch has been successfully rebased

@iPraveenParihar
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@iPraveenParihar
Copy link
Contributor

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

refresh

✅ Pull request refreshed

@iPraveenParihar Mergify
Copy link
Contributor

@Mergifyio queue default

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2024

queue default

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@iPraveenParihar
Copy link
Contributor

@Rakshith-R, can you take look at this?

Mergifyio can't queue due to

The merge queue pull request can't be updated
Details:

Unable to update: user mayankpall is unknown.

@Rakshith-R
Copy link
Contributor

@Mergifyio rebase

@mayankpall @Rakshith-R
ci: Use temporary directory for unit tests
84719b2 
ensure a clean and isolated environment for testing purposes.

Signed-off-by: Mayank Pal <mayankpal9654@gmail.com>

ci: Use temporary directory for unit tests

remove err = os.Mkdir('/etc/ceph-csi-config', 0o600)

Signed-off-by: Mayank Pal <mayankpal9654@gmail.com>

ci: Use temporary directory for unit tests

remove err = os.Mkdir('/etc/ceph-csi-config', 0o600)

Signed-off-by: Mayank Pal <mayankpal9654@gmail.com>

ci: Use temporary directory for unit tests

remove if err

Signed-off-by: Mayank Pal <mayankpal9654@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented May 27, 2024

rebase

✅ Branch has been successfully rebased

@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 27, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 822794c

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label May 27, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label May 27, 2024
@mergify mergify bot merged commit 822794c into ceph:devel May 27, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to run make go-test failed locally
5 participants
@mayankpall @iPraveenParihar @Madhu-1 @Rakshith-R @ceph-csi-bot