Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove k8s 1.30 tests check #4647

Merged
merged 1 commit into from
May 28, 2024
Merged

ci: remove k8s 1.30 tests check #4647

merged 1 commit into from
May 28, 2024

Conversation

iPraveenParihar
Copy link
Contributor

Describe what this PR does

k8s 1.30 tests were excluded for release-v3.11 but
mergify has status check condition for k8s 1.30 tests.
This commit removes these checks from mergify.

Related issues

Closes: #4625

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@iPraveenParihar iPraveenParihar added the ci/skip/e2e skip running e2e CI jobs label May 28, 2024
@mergify mergify bot added the component/testing Additional test cases or CI work label May 28, 2024
@iPraveenParihar iPraveenParihar self-assigned this May 28, 2024
@iPraveenParihar iPraveenParihar marked this pull request as ready for review May 28, 2024 10:30
Madhu-1
Madhu-1 reviewed May 28, 2024
View reviewed changes
.github/workflows/pull-request-commentor.yaml Outdated
Comment on lines 30 to 33
# Ceph-CSI <= 3.11 was released before Kubernetes 1.30
- k8s: "1.30"
branch: "release-v3.11"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for a mistake from my side, now i see that we don't support 1.30 with even patch releases. can you please remove 1.30 check from mergify.yaml where we have base~=^(release-.+)$ check and nothing else.

@iPraveenParihar
ci: remove k8s 1.30 tests from release-v3.11
f0bd741 
k8s 1.30 tests were excluded for release-v3.11 but
merigfy had 1.30 tests conditions for release-v3.11.
This commit remove the these conditions for v3.11.

Signed-off-by: Praveen M <m.praveen@ibm.com>
@Madhu-1 Madhu-1 requested a review from Rakshith-R May 28, 2024 10:51
Rakshith-R
Rakshith-R approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@iPraveenParihar
Copy link
Contributor Author

We also need to backport this to v3.11

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 28, 2024

@iPraveenParihar mergify rules are checked on only main/devel branch, if required we can backport it later.

@Madhu-1 Madhu-1 added the ci/skip/multi-arch-build skip building on multiple architectures label May 28, 2024
@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 28, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 28, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at ce3ec6a

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label May 28, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label May 28, 2024
@mergify mergify bot merged commit ce3ec6a into ceph:devel May 28, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees

@iPraveenParihar iPraveenParihar

Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: k8s 1.30 tests are excluded for release-v3.11
4 participants
@iPraveenParihar @Madhu-1 @ceph-csi-bot @Rakshith-R