Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update centos stream 8 baseurl #4658

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

iPraveenParihar
Copy link
Contributor

@iPraveenParihar iPraveenParihar commented Jun 4, 2024

Describe what this PR does

Since CentOS Stream 8 is EOL, this commit updates the config to use vault.centos.org for CentOS Stream 8.
This should be removed once the base image (ceph) is updated to a version with a newer CentOS.

update baseurl with: http://vault.centos.org

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added the component/testing Additional test cases or CI work label Jun 4, 2024
@iPraveenParihar
Copy link
Contributor Author

FYI,
CI was failing to build ceph-csi image

#8 [updated_base 4/4] RUN dnf -y update --nobest        && dnf -y install nfs-utils        && dnf clean all        && rm -rf /var/cache/yum
#8 0.555 CentOS Stream 8 - AppStream                     490  B/s |  38  B     00:00    
#8 0.563 Error: Failed to download metadata for repo 'appstream': Cannot prepare internal mirrorlist: No URLs in mirrorlist
#8 ERROR: process "/bin/sh -c dnf -y update --nobest        && dnf -y install nfs-utils        && dnf clean all        && rm -rf /var/cache/yum" did not complete successfully: exit code: 1
------
 > [updated_base 4/4] RUN dnf -y update --nobest        && dnf -y install nfs-utils        && dnf clean all        && rm -rf /var/cache/yum:
0.555 CentOS Stream 8 - AppStream                     490  B/s |  38  B     00:00    
0.563 Error: Failed to download metadata for repo 'appstream': Cannot prepare internal mirrorlist: No URLs in mirrorlist

CentOS 8 was EOL on 31 May 2024.
And quay.io/ceph/ceph:v18 is based on CentOS 8 stream. Probably that is the reason.

pm@dhcp53-176:~$ podman run --rm -it quay.io/ceph/ceph:v18 cat /etc/os-release
NAME="CentOS Stream"
VERSION="8"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="8"
PLATFORM_ID="platform:el8"
PRETTY_NAME="CentOS Stream 8"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:8"
HOME_URL="https://centos.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_SUPPORT_PRODUCT_VERSION="CentOS Stream"

Workaround for now will be to update the centos repo url.

@iPraveenParihar iPraveenParihar marked this pull request as ready for review June 4, 2024 05:57
@iPraveenParihar iPraveenParihar self-assigned this Jun 4, 2024
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.29

Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please open a issue and link it in TODO ?

Since CentOS Stream 8 is EOL, this commit updates the
config to use vault.centos.org for CentOS Stream 8.
This should be removed once the base image (ceph) is
updated to a version with a newer CentOS.

Signed-off-by: Praveen M <m.praveen@ibm.com>
@Rakshith-R Rakshith-R requested a review from a team June 5, 2024 06:50
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e/k8s-1.30

@iPraveenParihar
Copy link
Contributor Author

@Madhu-1, can we skip e2e tests for this PR?
I have run one to check if image is getting build or not. That should be enough?

@Madhu-1 Madhu-1 added the ci/skip/e2e skip running e2e CI jobs label Jun 5, 2024
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jun 5, 2024

@Madhu-1, can we skip e2e tests for this PR? I have run one to check if image is getting build or not. That should be enough?

@iPraveenParihar yes we can skip it, lets one E2E pass which you have already started

@Madhu-1 Madhu-1 removed the ci/skip/e2e skip running e2e CI jobs label Jun 5, 2024
@iPraveenParihar
Copy link
Contributor Author

@Madhu-1, can we skip e2e tests for this PR? I have run one to check if image is getting build or not. That should be enough?

@iPraveenParihar yes we can skip it, lets one E2E pass which you have already started

test has passed!

@iPraveenParihar
Copy link
Contributor Author

@Mergifyio queue

Copy link
Contributor

mergify bot commented Jun 5, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5809628

@Madhu-1 Madhu-1 added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Jun 5, 2024
@Rakshith-R
Copy link
Contributor

/test ci/centos/k8s-e2e-external-storage

@Rakshith-R
Copy link
Contributor

/test ci/centos/mini-e2e

@Rakshith-R
Copy link
Contributor

/test ci/centos/mini-e2e-helm

@Rakshith-R
Copy link
Contributor

/test ci/centos/upgrade-tests-cephfs

@Rakshith-R
Copy link
Contributor

/test ci/centos/upgrade-tests-rbd

@mergify mergify bot merged commit 5809628 into ceph:devel Jun 5, 2024
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants