Implement EncryptionKeyRotation spec #4690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
black-dragon74
commented
Jun 25, 2024
nixpanic
reviewed
Jun 25, 2024
|
Note: The CI failures are expected until: csi-addons/spec#65 is merged. |
black-dragon74
force-pushed
the
pvkr-feat
branch
from
98506e0
to
1a8fd84
Compare
black-dragon74
changed the title
|
I’ll take care of the failures since the linked PR is merged :) |
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
This patch also includes a few modifications and additions to exisiting helper functions Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
black-dragon74
force-pushed
the
pvkr-feat
branch
from
370b99a
to
448c870
Compare
|
@black-dragon74, please follow these conventions for the commit messages. |
nixpanic
reviewed
Jun 27, 2024
Thanks Praveen. I'll be squashing all the commits into one before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the EncryptionKeyRotation spec for ceph-csi