Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove global CSIInstanceID and pass configured value instead #4747

Merged
merged 2 commits into from
Aug 5, 2024
Merged

cleanup: remove global CSIInstanceID and pass configured value instead #4747

merged 2 commits into from
Aug 5, 2024

Commits on Aug 5, 2024

  1. util: add CSIDriver.GetInstanceID() 

    There has been some confusion about using different variables for the
InstanceID of the RBD-driver. By removing the global variable
CSIInstanceID, there should be no confusion anymore what variable to
use.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    c3a8cea View commit details
    Browse the repository at this point in the history

  2. cephfs: use conf.InstanceID instead of global variable 

    RBD does not have a global CSIInstanceID variable anymore, there is no
need for CephFS to use one either.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
    @nixpanic
    nixpanic committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    616c563 View commit details
    Browse the repository at this point in the history