Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: prevent incorrect pattern matching for skipping ci command #4754

Merged
merged 1 commit into from
Aug 9, 2024
Merged

ci: prevent incorrect pattern matching for skipping ci command #4754

merged 1 commit into from
Aug 9, 2024

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Aug 9, 2024 •
edited
Loading

No description provided.

@nixpanic
ci: prevent incorrect pattern matching for skipping ci command
67fe494 
Mergify matches `body-raw` as regular expression, but that makes it
difficult (if not impossible) to match the `[` in a string.

Fixes: ceph#4751
Signed-off-by: Niels de Vos <ndevos@ibm.com>
@mergify mergify bot added the component/testing Additional test cases or CI work label Aug 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 9, 2024

The PR description contains the unsupported [skip ci] command, please update the description and mark the PR ready for review again.

@mergify mergify bot marked this pull request as draft August 9, 2024 10:24
@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures ok-to-test Label to trigger E2E tests labels Aug 9, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 9, 2024
@nixpanic nixpanic marked this pull request as ready for review August 9, 2024 10:26
@mergify mergify bot marked this pull request as draft August 9, 2024 10:27
@nixpanic nixpanic marked this pull request as ready for review August 9, 2024 10:27
@nixpanic nixpanic requested a review from a team August 9, 2024 10:27
@nixpanic
Copy link
Member Author

nixpanic commented Aug 9, 2024

original description of the PR, removed to prevent mergify from marking this a draft again:

Mergify matches body-raw as regular expression, but that makes it
difficult (if not impossible) to match the [ in a string.

Fixes: #4751

@mergify mergify bot merged commit 2fd9257 into ceph:devel Aug 9, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nixpanic @ceph-csi-bot @iPraveenParihar @Rakshith-R