helm: don't specify default topology domainlabels in rbd chart (backport #4776) #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Madhu-1
approved these changes
Aug 19, 2024
mergify
bot
added
ok-to-test
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
Madhu-1
added
the
ready-to-merge
Rakshith-R
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the bad default, add commented-out standard labels as a suggestion.
Describe what this PR does
This fixes a problem I noticed while digging into #4775.
It brings the default
topology.domainLabelsvalue in line with what the README.md claims (default={}), and in line with what the installer manifest does (leaves the command-line parameter commented out).Is there anything that requires special attention
I believe this change is beneficial enough to stand on its own. That said, these label definitions are 4 years old, and I don't know what's different between the 3.11.0 and 3.12.0 releases to cause #4775 to occur now.
I had to work around the problem with
helm --set topology.domainLabels=[], which worked for me. This PR updates the default to reflect that, and updates the comments to suggest the standard topology labels.There are two places in the helm chart which reference this value, both are guarded with:
So I think it doesn't need to be an explicitly empty array (
[]), leaving the whole thing commented out is fine.Related issues
Fixes: #4775
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
This is an automatic backport of pull request #4776 done by [Mergify](https://mergify.com).