helm: Always add nodes read permissions to provisioner ClusterRole #4798
Conversation
mergify
bot
added
the
component/deployment
|
@Madhu-1 @iPraveenParihar can you please review? |
Madhu-1
added
the
backport-to-release-v3.12
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.31 |
|
@dragoangel "ci/centos/mini-e2e-helm/k8s-1.31" test failed. Logs are available at location for debugging |
|
/retest ci/centos/mini-e2e/k8s-1.31 |
|
@dragoangel "ci/centos/mini-e2e/k8s-1.31" test failed. Logs are available at location for debugging |
|
/retest ci/centos/upgrade-tests-cephfs |
|
@dragoangel "ci/centos/upgrade-tests-cephfs" test failed. Logs are available at location for debugging |
✅ The pull request has been removed from the queue
|
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
@Mergifyio rebase |
Signed-off-by: Dmytro Alieksieiev <1865999+dragoangel@users.noreply.github.com>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
fix-rbac-ceph-csi-rbd-provisioner
branch
from
eff81d5
to
7229c3a
Compare
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 601c40b |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
Hi any estimate when there will be a new chartrelease which include this fix? |
Yes please, it's breaking our deployments :/ |
|
Will do a release on next Monday |
|
cephcsi 3.12.2 release is out https://github.com/ceph/ceph-csi/releases/tag/v3.12.2 with this change |
|
@Madhu-1 thanks a lot 🚀 |
Describe what this PR does
--immediate-topology=falsenot stoppingregistry.k8s.io/sig-storage/csi-provisionerfrom attemps list nodes, like--feature-gates=Topology=falsedo, because of errors incsi-provisionercontainer will paper and it will not work. More details are described here: #4790 (comment)This PR adds permissions to allow
csi-provisionerlist nodes and csinodes even when.Values.topology.domainLabelsis[]which fixes mentioned above issue.Is there anything that requires special attention
Do you have any questions?
No
Is the change backward compatible?
Yes
Are there concerns around backward compatibility?
No
Provide any external context for the change, if any.
N/A
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
properly fixes: #4777
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)